Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduler worker #77

Merged
merged 12 commits into from
Apr 10, 2024
Merged

Scheduler worker #77

merged 12 commits into from
Apr 10, 2024

Conversation

happymancoder
Copy link
Contributor

Code changes

  • Add scheduler worker with cron expresssion
  • Add ClikView.Extensions.Hosting.Tests test project

@happymancoder happymancoder requested a review from MrSmoke April 8, 2024 06:43
MrSmoke
MrSmoke reviewed Apr 10, 2024
View reviewed changes
src/Hosting/Hosting/src/Workers/CronWorkerOption.cs Outdated
/// <summary>
/// Maximum extra time in second delayed before the scheduled task can start
/// </summary>
public uint MaxJitter { get; } = 120;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use TimeSpan here as its a bit more clear what the values should be

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@MrSmoke MrSmoke merged commit c04dbd4 into master Apr 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrSmoke MrSmoke MrSmoke approved these changes

Assignees

@MrSmoke MrSmoke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@happymancoder @MrSmoke