OAuth Authenticator updates #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the clock drift logic to when checking if expired instead of removing from the actual expire time stored
|
eyamenko
reviewed
Feb 20, 2024
| { | ||
| if (token == null) | ||
| return false; | ||
| if (token is null) |
There was a problem hiding this comment.
eyamenko
reviewed
Feb 20, 2024
| @@ -4,15 +4,17 @@ | |||
|
|
|||
| public static class TokenExtensions | |||
| { | |||
| public static bool IsValid(this Token token) | |||
| public static bool HasExpired(this Token token) | |||
| using IdentityModel.Client; | ||
| using Tokens; | ||
|
|
||
| public static class TokenHelpers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HelperstoTokenHelpersand change frominternaltopublicGetResourceOwnerPasswordTokenAsynctoTokenClientHasExpiredextension method toTokento check for expired tokensArray.Emptyovernew List<>