This repository has been archived by the owner on Jul 4, 2018. It is now read-only.
Update nightmare to the latest version 🚀 #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greenkeeper[bot]](https://avatars.githubusercontent.com/in/505?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
=======================================
Coverage 95.71% 95.71%
=======================================
Files 15 15
Lines 70 70
Branches 7 7
=======================================
Hits 67 67
Misses 3 3Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.
Version 3.0.0 of nightmare was just published.
The version 3.0.0 is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of nightmare.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
Commits
The new version differs by 55 commits.
bb99432Release 3.0.08c8fd96Merge pull request #1391 from segmentio/fix/serialize-errors8304e4efix: properly serialize & unserialize errors across processes7e9b2darefactor: remove window.__nightmare.ipc to resolve the major security issuead0c596Merge pull request #1394 from segmentio/remove/node-4045493efix: circleci. stop testing node 4 (thought it still works fine) because npm's peer dependencies are breaking6fa76b5Merge pull request #1386 from segmentio/add/linting88cfd47chore: add eslint recommended linting, prettier formatting, lock package manager version, and add a precommit hook8c882ecMerge pull request #1274 from segmentio/fix-tests93a5807Merge pull request #1282 from nimitmaru/patch-11203dc5move tests to a separate sectionf3613cfadd additional resources sectiona141e90Merge pull request #1381 from machadogj/selector-in-timeout3cb2b97RemoveNightmare.versionfrom the docs8cbb7ecfixed example and ran the readme through prettierThere are 55 commits in total.
See the full diff
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴