feat(clerk-js): Add option to disable development mode warning #4951
Conversation
🦋 Changeset detectedLatest commit: 4d3f63c The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/astro/src/env.d.ts
Outdated
| @@ -18,6 +18,7 @@ interface InternalEnv { | |||
| readonly PUBLIC_CLERK_SIGN_UP_URL?: string; | |||
| readonly PUBLIC_CLERK_TELEMETRY_DISABLED?: string; | |||
| readonly PUBLIC_CLERK_TELEMETRY_DEBUG?: string; | |||
| readonly PUBLIC_CLERK_DANGEROUSLY_DISABLE_DEVELOPMENT_MODE_WARNING?: string; | |||
There was a problem hiding this comment.
hm, we already have a ClerkProvider prop for disabling development mode called unsafe_disableDevelopmentModeWarnings https://clerk.com/docs/customization/layout#properties
There was a problem hiding this comment.
this is just within the appearance prop and only impacts the components...we need one for the console warning too 😢
There was a problem hiding this comment.
@brkalow isn't there also a dashboard toggle for this ? but i assume we don't want to redirect them there.
There was a problem hiding this comment.
@panteliselef I don't think so, but I'll check.
There was a problem hiding this comment.
I don't see a dashboard setting for this.
There was a problem hiding this comment.
i was wrong on this, yeah
Description
Adds an option to disable the development mode warning:
disableDevelopmentModeWarning.Some users are well aware of the dev mode warning and want to disable it. This is understandable, so we're adding an option here.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change