Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(localizations): Fix delete account action for nb-NO localization #4821

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

lasseklovstad
Copy link
Contributor

Description

Hi! There was no obvious way to delete the account in Norwegian because the translation was wrong compared to the formFieldInputPlaceholder__confirmDeletionUserAccount. SO this should fix it.

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: 7de0da3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/ui Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 11:16am

@anagstef anagstef changed the title fix(localization): Update deletPage translations for nb-NO fix(localization): Fix delete account action for nb-NO localization Dec 20, 2024
Copy link
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this fix! 🙏

@anagstef anagstef changed the title fix(localization): Fix delete account action for nb-NO localization fix(localizations): Fix delete account action for nb-NO localization Dec 20, 2024
@nikosdouvlis nikosdouvlis merged commit fa8be89 into clerk:main Dec 20, 2024
11 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants