fix(clerk-js): Fix broken enterprise connection icon for custom SAML provider #4809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ade9e69 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LauraBeatris
changed the title
mzhong9723
approved these changes
Dec 18, 2024
izaaklauer
approved these changes
Dec 18, 2024
NicolasLopes7
approved these changes
Dec 18, 2024
panteliselef
approved these changes
Dec 19, 2024
anagstef
approved these changes
Dec 19, 2024
LauraBeatris
force-pushed
the
laura/orgs-434-fix-broken-icon-for-custom-saml-account-connection-type-on
branch
from
dcd6f7c to
e872809
Compare
LauraBeatris
force-pushed
the
laura/orgs-434-fix-broken-icon-for-custom-saml-account-connection-type-on
branch
from
e872809 to
ade9e69
Compare
LauraBeatris
deleted the
laura/orgs-434-fix-broken-icon-for-custom-saml-account-connection-type-on
branch
BRKalow
pushed a commit
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves ORGS-434
Previously, it was merging the provider key to our CDN URL, therefore SAML custom was resolving to an invalid path/asset:
FAPI already returns a logo URL which is serialized for each enterprise connection type, and we can always trust that now instead of concatenating manually.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change