feat(clerk-js): Redirect to current page when within modal and no redirect url is provided #4762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8888795 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alexcarpenter
changed the title
| * When we're in modal mode and no redirect_url is provided, we want to redirect to the current page after sign-in or sign-up. | ||
| */ | ||
| export const determineRedirectUrlFromMode = ({ mode, url, clerk }: { mode: Mode; url: string; clerk: Clerk }) => { | ||
| return mode === 'modal' && url === '/' ? window.location.href : clerk.buildUrlWithAuth(url); |
There was a problem hiding this comment.
what if afterSignInUrl was set explicitly to / ?
Maybe this logic should exists inside new RedirectUrls()
There was a problem hiding this comment.
Yeah thats is a good call, opened a separate PR with that approach here #4768
|
closing in favor of #4768 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For our
<SignInButton />and<SignUpButton />usage whenmode="modal"and no redirect url is provided, fallback to redirecting to the current page vs being redirected to/.Resolves SDKI-616
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change