Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elements): Handle ticket-based sign-in flow #4746

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Dec 10, 2024

Description

Resolves SDK-2002

Handles ticket-based invitation sign-sign flows. This fixes a current issue where impersonation won't work for sign-in pages built with @clerk/elements

CleanShot 2024-12-10 at 12 10 29

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@LauraBeatris LauraBeatris self-assigned this Dec 10, 2024
Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: 8a98a36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clerk/elements Minor
@clerk/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 3:13pm

@LauraBeatris
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @LauraBeatris - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 2.0.1-snapshot.v20241210112914
@clerk/backend 1.20.3-snapshot.v20241210112914
@clerk/chrome-extension 2.0.9-snapshot.v20241210112914
@clerk/clerk-js 5.40.3-snapshot.v20241210112914
@clerk/elements 0.22.0-snapshot.v20241210112914
@clerk/clerk-expo 2.4.5-snapshot.v20241210112914
@clerk/expo-passkeys 0.0.17-snapshot.v20241210112914
@clerk/express 1.3.26-snapshot.v20241210112914
@clerk/fastify 2.0.28-snapshot.v20241210112914
@clerk/localizations 3.8.2-snapshot.v20241210112914
@clerk/nextjs 6.8.3-snapshot.v20241210112914
@clerk/nuxt 0.0.13-snapshot.v20241210112914
@clerk/clerk-react 5.19.3-snapshot.v20241210112914
@clerk/react-router 0.0.2-snapshot.v20241210112914
@clerk/remix 4.3.6-snapshot.v20241210112914
@clerk/clerk-sdk-node 5.0.77-snapshot.v20241210112914
@clerk/shared 2.19.4-snapshot.v20241210112914
@clerk/tanstack-start 0.7.0-snapshot.v20241210112914
@clerk/testing 1.3.38-snapshot.v20241210112914
@clerk/themes 2.1.55-snapshot.v20241210112914
@clerk/types 4.39.2-snapshot.v20241210112914
@clerk/ui 0.2.4-snapshot.v20241210112914
@clerk/vue 0.0.17-snapshot.v20241210112914

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/[email protected] --save-exact

@clerk/backend

npm i @clerk/[email protected] --save-exact

@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/elements

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@clerk/expo-passkeys

npm i @clerk/[email protected] --save-exact

@clerk/express

npm i @clerk/[email protected] --save-exact

@clerk/fastify

npm i @clerk/[email protected] --save-exact

@clerk/localizations

npm i @clerk/[email protected] --save-exact

@clerk/nextjs

npm i @clerk/[email protected] --save-exact

@clerk/nuxt

npm i @clerk/[email protected] --save-exact

@clerk/clerk-react

npm i @clerk/[email protected] --save-exact

@clerk/react-router

npm i @clerk/[email protected] --save-exact

@clerk/remix

npm i @clerk/[email protected] --save-exact

@clerk/clerk-sdk-node

npm i @clerk/[email protected] --save-exact

@clerk/shared

npm i @clerk/[email protected] --save-exact

@clerk/tanstack-start

npm i @clerk/[email protected] --save-exact

@clerk/testing

npm i @clerk/[email protected] --save-exact

@clerk/themes

npm i @clerk/[email protected] --save-exact

@clerk/types

npm i @clerk/[email protected] --save-exact

@clerk/ui

npm i @clerk/[email protected] --save-exact

@clerk/vue

npm i @clerk/[email protected] --save-exact

@LauraBeatris LauraBeatris force-pushed the laura/fix-elements-impersonation branch from d54800b to 8a98a36 Compare December 10, 2024 15:11
@LauraBeatris LauraBeatris requested review from tmilewski and a team December 10, 2024 15:14
@LauraBeatris LauraBeatris marked this pull request as ready for review December 10, 2024 15:14
@LauraBeatris LauraBeatris merged commit 383cd29 into main Dec 10, 2024
29 checks passed
@LauraBeatris LauraBeatris deleted the laura/fix-elements-impersonation branch December 10, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants