Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(repo): Introduce job to check triggering actor permissions #4702

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

LauraBeatris
Copy link
Member

Description

This must be merged first to enable CI execution in PR #4692 before introducing pull_request_target

Introduces a job to validate the triggering actor's permissions, enabling conditional execution of other jobs.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@LauraBeatris LauraBeatris self-assigned this Dec 3, 2024
Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 0:47am

Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: 8dd9ea4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LauraBeatris LauraBeatris force-pushed the laura/ci-permissions-check branch from 1fa1d25 to 173075e Compare December 3, 2024 14:36
@LauraBeatris LauraBeatris marked this pull request as ready for review December 3, 2024 14:36
@LauraBeatris LauraBeatris requested a review from a team December 3, 2024 14:37
@@ -157,23 +182,6 @@ jobs:
next-version: '15'

steps:
# Skip integration tests from fork PRs to prevent secret exfiltration
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was individually running for integration tests, but we run should place it on the root, before running the setup for Turborepo + Blacksmith.

@LauraBeatris LauraBeatris force-pushed the laura/ci-permissions-check branch 2 times, most recently from 6e6eb67 to e531334 Compare December 4, 2024 12:42
@LauraBeatris LauraBeatris merged commit 8db1195 into main Dec 9, 2024
28 checks passed
@LauraBeatris LauraBeatris deleted the laura/ci-permissions-check branch December 9, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants