Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(localization): Update translations for multiple languages (BE, BG, CA, C… #4697

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .changeset/clean-rivers-sleep.md

This file was deleted.

7 changes: 0 additions & 7 deletions .changeset/dry-cats-change.md

This file was deleted.

2 changes: 0 additions & 2 deletions .changeset/funny-fishes-learn.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/fuzzy-carrots-push.md

This file was deleted.

10 changes: 0 additions & 10 deletions .changeset/grumpy-camels-think.md

This file was deleted.

11 changes: 0 additions & 11 deletions .changeset/itchy-cats-drive.md

This file was deleted.

7 changes: 0 additions & 7 deletions .changeset/loud-balloons-grow.md

This file was deleted.

5 changes: 5 additions & 0 deletions .changeset/quiet-ducks-vanish.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/localizations': major
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this should not bump the major version of the package.

---

Added and updated translations for fi-FI, bg-BG, ca-ES, cs-CZ, da-DK, de-DE, en-US, es-ES, fr-FR, nl-NL, pt-BR, pt-PT, tr-TR.
5 changes: 0 additions & 5 deletions .changeset/smooth-colts-shake.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/tasty-paws-agree.md

This file was deleted.

6 changes: 0 additions & 6 deletions .changeset/warm-spiders-develop.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/witty-icons-turn.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/young-lemons-marry.md

This file was deleted.

10 changes: 0 additions & 10 deletions integration/presets/envs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -113,15 +113,6 @@ const withWaitlistdMode = withEmailCodes
.setEnvVariable('private', 'CLERK_SECRET_KEY', instanceKeys.get('with-waitlist-mode').sk)
.setEnvVariable('public', 'CLERK_PUBLISHABLE_KEY', instanceKeys.get('with-waitlist-mode').pk);

const withCombinedFlow = withEmailCodes
.clone()
.setId('withCombinedFlow')
.setEnvVariable('private', 'CLERK_SECRET_KEY', instanceKeys.get('with-email-codes').sk)
.setEnvVariable('public', 'CLERK_PUBLISHABLE_KEY', instanceKeys.get('with-email-codes').pk)
.setEnvVariable('public', 'EXPERIMENTAL_COMBINED_FLOW', 'true')
.setEnvVariable('public', 'CLERK_SIGN_IN_URL', '/sign-in')
.setEnvVariable('public', 'CLERK_SIGN_UP_URL', '/sign-in');

export const envs = {
base,
withEmailCodes,
Expand All @@ -138,5 +129,4 @@ export const envs = {
withRestrictedMode,
withLegalConsent,
withWaitlistdMode,
withCombinedFlow,
} as const;
1 change: 0 additions & 1 deletion integration/presets/longRunningApps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ export const createLongRunningApps = () => {
},
{ id: 'next.appRouter.withCustomRoles', config: next.appRouter, env: envs.withCustomRoles },
{ id: 'next.appRouter.withReverification', config: next.appRouter, env: envs.withReverification },
{ id: 'next.appRouter.withCombinedFlow', config: next.appRouter, env: envs.withCombinedFlow },
{ id: 'quickstart.next.appRouter', config: next.appRouterQuickstart, env: envs.withEmailCodesQuickstart },
{ id: 'elements.next.appRouter', config: elements.nextAppRouter, env: envs.withEmailCodes },
{ id: 'astro.node.withCustomRoles', config: astro.node, env: envs.withCustomRoles },
Expand Down
6 changes: 3 additions & 3 deletions integration/presets/vue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ const vite = applicationConfig()
.useTemplate(templates['vue-vite'])
.setEnvFormatter('public', key => `VITE_${key}`)
.addScript('setup', 'pnpm install')
.addScript('dev', 'pnpm dev')
.addScript('build', 'pnpm build')
.addScript('serve', 'pnpm preview')
.addScript('dev', 'npm run dev')
.addScript('build', 'npm run build')
.addScript('serve', 'npm run preview')
.addDependency('@clerk/vue', '*');

export const vue = {
Expand Down
3 changes: 0 additions & 3 deletions integration/templates/next-app-router/src/app/layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ export default function RootLayout({ children }: { children: React.ReactNode })
return (
<ClerkProvider
experimental={{
combinedFlow: process.env.NEXT_PUBLIC_EXPERIMENTAL_COMBINED_FLOW
? process.env.NEXT_PUBLIC_EXPERIMENTAL_COMBINED_FLOW === 'true'
: undefined,
persistClient: process.env.NEXT_PUBLIC_EXPERIMENTAL_PERSIST_CLIENT
? process.env.NEXT_PUBLIC_EXPERIMENTAL_PERSIST_CLIENT === 'true'
: undefined,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ export default function Page() {
routing={'path'}
path={'/sign-in'}
signUpUrl={'/sign-up'}
__experimental={{
combinedProps: {},
}}
/>
</div>
);
Expand Down
5 changes: 2 additions & 3 deletions integration/templates/vue-vite/src/App.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<script setup lang="ts">
import { SignedIn, SignedOut, OrganizationSwitcher, ClerkLoaded, ClerkLoading } from '@clerk/vue';
import CustomUserButton from './components/CustomUserButton.vue';
import { SignedIn, SignedOut, UserButton, OrganizationSwitcher, ClerkLoaded, ClerkLoading } from '@clerk/vue';
</script>

<template>
Expand All @@ -10,7 +9,7 @@ import CustomUserButton from './components/CustomUserButton.vue';
<p class="title">Vue Clerk Integration test</p>
</div>
<SignedIn>
<CustomUserButton />
<UserButton />
<OrganizationSwitcher />
</SignedIn>
<SignedOut>
Expand Down
52 changes: 0 additions & 52 deletions integration/templates/vue-vite/src/components/CustomUserButton.vue

This file was deleted.

13 changes: 1 addition & 12 deletions integration/templates/vue-vite/src/router.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,6 @@ const routes = [
path: '/unstyled',
component: () => import('./views/Unstyled.vue'),
},
{
name: 'CustomUserProfile',
path: '/custom-pages/user-profile',
component: () => import('./views/custom-pages/UserProfile.vue'),
},
{
name: 'CustomOrganizationProfile',
path: '/custom-pages/organization-profile',
component: () => import('./views/custom-pages/OrganizationProfile.vue'),
},
];

const router = createRouter({
Expand All @@ -45,15 +35,14 @@ const router = createRouter({

router.beforeEach(async (to, _, next) => {
const { isSignedIn, isLoaded } = useAuth();
const authenticatedPages = ['Profile', 'Admin', 'CustomUserProfile', 'CustomOrganizationProfile'];

if (!isLoaded.value) {
await waitForClerkJsLoaded(isLoaded);
}

if (isSignedIn.value && to.name === 'Sign in') {
next('/profile');
} else if (!isSignedIn.value && authenticatedPages.includes(to.name)) {
} else if (!isSignedIn.value && ['Profile', 'Admin'].includes(to.name as string)) {
next('/sign-in');
} else {
next();
Expand Down

This file was deleted.

This file was deleted.

3 changes: 1 addition & 2 deletions integration/testUtils/commonPageObject.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ export const common = ({ page }: TestArgs) => {
},
enterOtpCode: async (code: string) => {
await page.getByRole('textbox', { name: /digit 1/i }).click();
// We've got a delay here to ensure the prepare call is triggered before the OTP is auto-submitted.
await page.keyboard.type(code, { delay: 100 });
await page.keyboard.type(code, { delay: 50 });
},
enterTestOtpCode: async () => {
return self.enterOtpCode('424242');
Expand Down
Loading
Loading