Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(astro): Add backwards compatibility for ignoring prerendered routes in Astro middleware #4694

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

wobsoriano
Copy link
Member

Description

This PR is a follow up to #4640 which ignores prerendered routes in Clerk Astro middleware.

The v4 version of Astro uses _isPrerendered property while v5 uses isPrerendered.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: cfbbd33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 11:27pm

@wobsoriano wobsoriano marked this pull request as ready for review December 2, 2024 23:26
@wobsoriano wobsoriano changed the title chore(astro): Add backwards compatibility for ignoring prerendered routes in Astro v4 chore(astro): Add backwards compatibility for ignoring prerendered routes in Astro Dec 3, 2024
@wobsoriano wobsoriano changed the title chore(astro): Add backwards compatibility for ignoring prerendered routes in Astro chore(astro): Add backwards compatibility for ignoring prerendered routes in Astro middleware Dec 3, 2024
@LekoArts LekoArts merged commit 30f8e82 into main Dec 3, 2024
31 checks passed
@LekoArts LekoArts deleted the rob/astro-ignore-prerendered-pages branch December 3, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants