-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(clerk-js,types): Add experimental SignInCombinedProps
option
#4691
chore(clerk-js,types): Add experimental SignInCombinedProps
option
#4691
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
const { componentName, ..._ctx } = context; | ||
const ctx = _ctx.__experimental?.combinedProps || _ctx; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these lines be reversed?
const { componentName, ..._ctx } = context; | |
const ctx = _ctx.__experimental?.combinedProps || _ctx; | |
const ctx = _ctx.__experimental?.combinedProps || _ctx; | |
const { componentName, ..._ctx } = context; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, componentName
only lives on the SignInCtx
so we pull that off from the original context
and the use the rest of the props as the context values below based on the usage of combinedProps
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh I missed the _
😅
a20a08c
into
alexcarpenter/sign-in-up-flow-init
Description
Resolves SDKI-751
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change