Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clerk-js,types): Add experimental SignInCombinedProps option #4691

Conversation

alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Dec 2, 2024

Description

Resolves SDKI-751

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: dadb049

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 7:58pm

Comment on lines +40 to +41
const { componentName, ..._ctx } = context;
const ctx = _ctx.__experimental?.combinedProps || _ctx;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these lines be reversed?

Suggested change
const { componentName, ..._ctx } = context;
const ctx = _ctx.__experimental?.combinedProps || _ctx;
const ctx = _ctx.__experimental?.combinedProps || _ctx;
const { componentName, ..._ctx } = context;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, componentName only lives on the SignInCtx so we pull that off from the original context and the use the rest of the props as the context values below based on the usage of combinedProps.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I missed the _ 😅

@alexcarpenter alexcarpenter merged commit a20a08c into alexcarpenter/sign-in-up-flow-init Dec 3, 2024
6 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/combined-flow-props branch December 3, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants