Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js,localizations,types): Enable email verification in UserProfile via enterprise SSO #4406

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

NicolasLopes7
Copy link
Contributor

@NicolasLopes7 NicolasLopes7 commented Oct 24, 2024

Description

Resolves ORGS-395

Introduces the ability to verify an email address based on an existing enterprise SSO connection. It supports the following use case:

  • User tests an app within their workspace.
  • Their organization upgrades to the SaaS enterprise plan.
  • SaaS owner sets up SSO for the organization via Clerk.
  • User adds their organization email in their profile, triggering SSO verification

CleanShot 2024-12-18 at 16 28 27@2x

CleanShot.2024-12-18.at.17.43.36.mp4

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Oct 24, 2024

🦋 Changeset detected

Latest commit: 0f96abf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@clerk/types Minor
@clerk/localizations Minor
@clerk/clerk-js Minor
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/clerk-expo Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/shared Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/ui Patch
@clerk/vue Patch
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@NicolasLopes7 NicolasLopes7 changed the title wip orgs-236: wip Oct 24, 2024
@LauraBeatris LauraBeatris changed the title orgs-236: wip feat(clerk-js): Support verification with enterprise SSO Dec 2, 2024
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 8:52pm

@LauraBeatris LauraBeatris changed the title feat(clerk-js): Support verification with enterprise SSO feat(clerk-js): Support verification with enterprise SSO Dec 2, 2024
@LauraBeatris LauraBeatris changed the title feat(clerk-js): Support verification with enterprise SSO feat(clerk-js, localizations): Support verification with enterprise SSO Dec 3, 2024
@LauraBeatris LauraBeatris changed the title feat(clerk-js, localizations): Support verification with enterprise SSO feat(clerk-js,localizations): Support verification with enterprise SSO Dec 3, 2024
@LauraBeatris LauraBeatris changed the title feat(clerk-js,localizations): Support verification with enterprise SSO feat(clerk-js,localizations,types): Enable email verification in UserProfile via enterprise SSO Dec 3, 2024
@@ -164,7 +164,7 @@ const ConnectedAccount = ({ account }: { account: ExternalAccountResource }) =>
<ImageOrInitial />
<Box sx={{ whiteSpace: 'nowrap', overflow: 'hidden' }}>
<Flex
gap={2}
gap={1}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes an issue with the spacing between the provider and email address:

With gap 1:

CleanShot 2024-12-06 at 07 38 19

With gap 2:

CleanShot 2024-12-06 at 07 37 55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants