-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(nextjs): Support unstable_rethrow inside clerkMiddleware #4347
Merged
jacekradko
merged 10 commits into
feat/nextjs-15-compat
from
elef/sdki-708-support-unstable_rethrow-inside-clerkmiddleware
Oct 22, 2024
Merged
chore(nextjs): Support unstable_rethrow inside clerkMiddleware #4347
jacekradko
merged 10 commits into
feat/nextjs-15-compat
from
elef/sdki-708-support-unstable_rethrow-inside-clerkmiddleware
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4ed45dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
requested review from
nikosdouvlis,
BRKalow,
dstaley and
jacekradko
October 17, 2024 13:44
jacekradko
reviewed
Oct 21, 2024
…ble_rethrow-inside-clerkmiddleware
…ble_rethrow-inside-clerkmiddleware
jacekradko
deleted the
elef/sdki-708-support-unstable_rethrow-inside-clerkmiddleware
branch
October 22, 2024 05:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We changed the errors thrown by
protect()
insideclerkMiddleware
in order forunstable_rethrow
to recognise them and rethrow them.Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change