Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nextjs): Support unstable_rethrow inside clerkMiddleware #4347

Conversation

panteliselef
Copy link
Member

@panteliselef panteliselef commented Oct 17, 2024

Description

We changed the errors thrown by protect() inside clerkMiddleware in order for unstable_rethrow to recognise them and rethrow them.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: 4ed45dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/nextjs Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef panteliselef self-assigned this Oct 18, 2024
@jacekradko jacekradko changed the base branch from main to feat/nextjs-15-compat October 21, 2024 23:49
@jacekradko jacekradko merged commit 7149cc2 into feat/nextjs-15-compat Oct 22, 2024
2 of 3 checks passed
@jacekradko jacekradko deleted the elef/sdki-708-support-unstable_rethrow-inside-clerkmiddleware branch October 22, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants