fix(tanstack-start): Merge router context instead of updating #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 81f84d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
octoper
changed the title
octoper
force-pushed
the
jw/merge-initial-context
branch
from
9dce162 to
c734a43
Compare
octoper
reviewed
Oct 27, 2024
octoper
changed the title
7 tasks
octoper
force-pushed
the
jw/merge-initial-context
branch
from
6c3268e to
3cb80bd
Compare
|
Will this be merged before the next release? It's currently breaking all TanStack Start apps that use the router context during SSR. |
octoper
force-pushed
the
jw/merge-initial-context
branch
5 times, most recently
from
4f331c4 to
63dfb52
Compare
|
Hey @phibr0 ! I'm working on this today and I will try to have it merged by the end of the day |
octoper
force-pushed
the
jw/merge-initial-context
branch
from
63dfb52 to
81f84d1
Compare
octoper
changed the base branch from
main
to
vaggelis.fix/merge-initial-context
octoper
merged commit 9655f31
into
clerk:vaggelis.fix/merge-initial-context
8 of 21 checks passed
|
Work for this issue has been moved on this PR |
octoper
added a commit
that referenced
this pull request
Oct 29, 2024
Co-authored-by: Vaggelis Yfantis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes bug where the initialisation of Clerk overwrites the context, by merging the original/existing context with the
clerkInitialState.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change