Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js,types,backend): Use EIP-4361 message spec for Web3 wallets #4334

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/violet-games-dream.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@clerk/clerk-js": minor
"@clerk/backend": minor
"@clerk/types": minor
---

Use EIP-4361 message spec for Web3 wallets sign in signature requests
1 change: 1 addition & 0 deletions packages/backend/src/api/resources/JSON.ts
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ export interface VerificationJSON extends ClerkResourceJSON {
verified_at_client?: string;
external_verification_redirect_url?: string | null;
nonce?: string | null;
message?: string | null;
}

export interface Web3WalletJSON extends ClerkResourceJSON {
Expand Down
1 change: 1 addition & 0 deletions packages/backend/src/api/resources/Verification.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export class Verification {
readonly attempts: number | null = null,
readonly expireAt: number | null = null,
readonly nonce: string | null = null,
readonly message: string | null = null,
) {}

static fromJSON(data: VerificationJSON): Verification {
Expand Down
8 changes: 4 additions & 4 deletions packages/clerk-js/src/core/resources/SignIn.ts
Original file line number Diff line number Diff line change
Expand Up @@ -250,14 +250,14 @@ export class SignIn extends BaseResource implements SignInResource {

await this.prepareFirstFactor(web3FirstFactor);

const { nonce } = this.firstFactorVerification;
if (!nonce) {
const { message } = this.firstFactorVerification;
if (!message) {
clerkVerifyWeb3WalletCalledBeforeCreate('SignIn');
}

let signature: string;
try {
signature = await generateSignature({ identifier, nonce, provider });
signature = await generateSignature({ identifier, nonce: message, provider });
} catch (err) {
// There is a chance that as a user when you try to setup and use the Coinbase Wallet with an existing
// Passkey in order to authenticate, the initial generate signature request to be rejected. For this
Expand All @@ -266,7 +266,7 @@ export class SignIn extends BaseResource implements SignInResource {
// error code 4001 means the user rejected the request
// Reference: https://docs.cdp.coinbase.com/wallet-sdk/docs/errors
if (provider === 'coinbase_wallet' && err.code === 4001) {
signature = await generateSignature({ identifier, nonce, provider });
signature = await generateSignature({ identifier, nonce: message, provider });
} else {
throw err;
}
Expand Down
8 changes: 4 additions & 4 deletions packages/clerk-js/src/core/resources/SignUp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -203,14 +203,14 @@ export class SignUp extends BaseResource implements SignUpResource {
await this.create({ web3Wallet, unsafeMetadata });
await this.prepareWeb3WalletVerification({ strategy });

const { nonce } = this.verifications.web3Wallet;
if (!nonce) {
const { message } = this.verifications.web3Wallet;
if (!message) {
clerkVerifyWeb3WalletCalledBeforeCreate('SignUp');
}

let signature: string;
try {
signature = await generateSignature({ identifier, nonce, provider });
signature = await generateSignature({ identifier, nonce: message, provider });
} catch (err) {
// There is a chance that as a first time visitor when you try to setup and use the
// Coinbase Wallet from scratch in order to authenticate, the initial generate
Expand All @@ -220,7 +220,7 @@ export class SignUp extends BaseResource implements SignUpResource {
// error code 4001 means the user rejected the request
// Reference: https://docs.cdp.coinbase.com/wallet-sdk/docs/errors
if (provider === 'coinbase_wallet' && err.code === 4001) {
signature = await generateSignature({ identifier, nonce, provider });
signature = await generateSignature({ identifier, nonce: message, provider });
} else {
throw err;
}
Expand Down
2 changes: 2 additions & 0 deletions packages/clerk-js/src/core/resources/Verification.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export class Verification extends BaseResource implements VerificationResource {
status: VerificationStatus | null = null;
strategy: string | null = null;
nonce: string | null = null;
message: string | null = null;
externalVerificationRedirectURL: URL | null = null;
attempts: number | null = null;
expireAt: Date | null = null;
Expand All @@ -44,6 +45,7 @@ export class Verification extends BaseResource implements VerificationResource {
this.verifiedAtClient = data.verified_at_client;
this.strategy = data.strategy;
this.nonce = data.nonce || null;
this.message = data.message || null;
if (data.external_verification_redirect_url) {
this.externalVerificationRedirectURL = new URL(data.external_verification_redirect_url);
} else {
Expand Down
4 changes: 2 additions & 2 deletions packages/clerk-js/src/ui/components/UserProfile/Web3Form.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ export const AddWeb3WalletActionMenu = withCardStateProvider(() => {

let web3Wallet = await user.createWeb3Wallet({ web3Wallet: identifier });
web3Wallet = await web3Wallet.prepareVerification({ strategy });
const nonce = web3Wallet.verification.nonce as string;
const signature = await generateWeb3Signature({ identifier, nonce, provider });
const message = web3Wallet.verification.message as string;
const signature = await generateWeb3Signature({ identifier, nonce: message, provider });
await web3Wallet.attemptVerification({ signature });
card.setIdle();
} catch (err) {
Expand Down
15 changes: 5 additions & 10 deletions packages/clerk-js/src/utils/web3.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@ export async function getWeb3Identifier(params: GetWeb3IdentifierParams): Promis
return (identifiers && identifiers[0]) || '';
}

type GenerateWeb3SignatureParams = {
identifier: string;
nonce: string;
type GenerateWeb3SignatureParams = GenerateSignatureParams & {
provider: Web3Provider;
};

Expand Down Expand Up @@ -55,15 +53,12 @@ type GenerateSignatureParams = {
nonce: string;
};

export async function generateSignatureWithMetamask({ identifier, nonce }: GenerateSignatureParams): Promise<string> {
return await generateWeb3Signature({ identifier, nonce, provider: 'metamask' });
export async function generateSignatureWithMetamask(params: GenerateSignatureParams): Promise<string> {
return await generateWeb3Signature({ ...params, provider: 'metamask' });
}

export async function generateSignatureWithCoinbaseWallet({
identifier,
nonce,
}: GenerateSignatureParams): Promise<string> {
return await generateWeb3Signature({ identifier, nonce, provider: 'coinbase_wallet' });
export async function generateSignatureWithCoinbaseWallet(params: GenerateSignatureParams): Promise<string> {
return await generateWeb3Signature({ ...params, provider: 'coinbase_wallet' });
}

async function getEthereumProvider(provider: Web3Provider) {
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/json.ts
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,7 @@ export interface VerificationJSON extends ClerkResourceJSON {
verified_at_client: string;
strategy: string;
nonce?: string;
message?: string;
external_verification_redirect_url?: string;
attempts: number;
expire_at: number;
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/verification.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ export interface VerificationResource extends ClerkResource {
expireAt: Date | null;
externalVerificationRedirectURL: URL | null;
nonce: string | null;
message: string | null;
status: VerificationStatus | null;
strategy: string | null;
verifiedAtClient: string | null;
Expand Down
Loading