Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js): Add Rsdoctor support #4212

Merged
merged 4 commits into from
Sep 26, 2024
Merged

feat(clerk-js): Add Rsdoctor support #4212

merged 4 commits into from
Sep 26, 2024

Conversation

dstaley
Copy link
Member

@dstaley dstaley commented Sep 24, 2024

Description

This PR adds support for Rsdoctor, a more robust bundle analysis tool.

You can enable it by setting the RSDOCTOR environment variable. Setting the env var to brief will output the report as a single HTML file to .rsdoctor and exit. Setting it to any other value will spawn a server and open the report in the browser.

Note: brief mode does not support multiple entry points, so you will need to manually disable all entry points besides the one you want to generate a report for.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: c80cb28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@nikosdouvlis nikosdouvlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@dstaley dstaley marked this pull request as ready for review September 25, 2024 18:16
@dstaley dstaley merged commit 2dbcd3f into main Sep 26, 2024
20 checks passed
@dstaley dstaley deleted the ds.feat/rsdoctor branch September 26, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants