Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(localizations): Update de-DE translation to be GDPR-compliant #4195

Merged

Conversation

serbanradulescu
Copy link
Contributor

@serbanradulescu serbanradulescu commented Sep 19, 2024

Description

The confirmation prompt under deletePage["confirm"] currently displays ‘Konto löschen’, while the placeholder and required input are ‘Account löschen’.

Given the importance of clarity in account deletion processes, especially in GDPR-compliant countries like Germany, this adjustment prevents any potential confusion or hindrance to users attempting to delete their account.”

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

The confirmation prompt under deletePage["confirm"] currently displays ‘Konto löschen’, while the placeholder and required input are ‘Account löschen’.

Given the importance of clarity in account deletion processes, especially in GDPR-compliant countries like Germany, this adjustment prevents any potential confusion or hindrance to users attempting to delete their account.”
Copy link

changeset-bot bot commented Sep 19, 2024

🦋 Changeset detected

Latest commit: e18da43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LauraBeatris LauraBeatris changed the title fix: inconsistency in translation in German GDPR-compliant fix(localizations): Remove inconsistency in translation in German GDPR-compliant Oct 1, 2024
@LauraBeatris
Copy link
Member

@serbanradulescu thanks for the contribution! Can you add a changeset that describes the change? 😄

https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md explains how to do this

@LauraBeatris LauraBeatris changed the title fix(localizations): Remove inconsistency in translation in German GDPR-compliant fix(localizations): Update de-DE translation to be GDPR-compliant Oct 1, 2024
@tmilewski tmilewski enabled auto-merge (squash) October 4, 2024 17:42
@tmilewski tmilewski disabled auto-merge October 4, 2024 17:51
@tmilewski tmilewski merged commit e29a806 into clerk:main Oct 4, 2024
6 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants