refactor(ui): Enforce i18n across form fields #3836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 46fcc3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joe-bell
force-pushed
the
joe-bell/SDKI-497
branch
from
7910dac to
4325768
Compare
joe-bell
commented
Jul 30, 2024
Comment on lines
+18
to
+21
| /** | ||
| * **Note:** this prop is required as the translation differs between `signIn` and `signUp` | ||
| */ | ||
| toggleLabelEmailOrUsername: React.ReactNode; |
There was a problem hiding this comment.
This use of inline docs came from a chat with @dstaley; making sure any unique/different approaches are accompanied by implementation details
Additionally, by using comment blocks, we can surface these notes through the props
alexcarpenter
approved these changes
Jul 30, 2024
brkalow
pushed a commit
that referenced
this pull request
Aug 1, 2024
wobsoriano
pushed a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
labeletc. by defining all translated content within the components themselves (unless the content explicitly needs to be changed)translateErrorwhere availableChecklist
npm testruns as expected.npm run buildruns as expected.Type of change