fix(clerk-js): Improve UX for recoverable actions in ConnectedAccounts #3723
Conversation
🦋 Changeset detectedLatest commit: 24d20bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
changed the title
panteliselef
force-pushed
the
elef/user-213-make-error-user-friendly-when-refresh-token-does-not-exist
branch
from
688bff2 to
f37d01b
Compare
packages/localizations/src/en-US.ts
Outdated
| @@ -458,6 +458,7 @@ export const enUS: LocalizationResource = { | |||
| 'Sign up unsuccessful due to failed security validations. Please refresh the page to try again or reach out to support for more assistance.', | |||
| captcha_unavailable: | |||
| 'Sign up unsuccessful due to failed bot validation. Please refresh the page to try again or reach out to support for more assistance.', | |||
| external_account_missing_refresh_token: 'This account has been disconnected', | |||
There was a problem hiding this comment.
A better message might be the following:
This account is missing a refresh token or There is no associated refresh token with this account
Maybe we need to provide the steps that the user needs to do in order to resolve this e.g. Try to reconnect your account or sign in
There was a problem hiding this comment.
I understand were you are coming from, but we are explicitly using a very simple message here, because this is something the end user will see. I am confident that unless you are a developer you are not aware of what a "refresh token" is, so the error message would not be that useful to you.
| @@ -305,6 +305,10 @@ export const arSA: LocalizationResource = { | |||
| title: 'التحقق من البريد الإلكتروني', | |||
| }, | |||
| emailLink: { | |||
| clientMismatch: { | |||
There was a problem hiding this comment.
❓ Are these changes related to connected accounts?
There was a problem hiding this comment.
No, i had to run the script that autogenerates all other localization with undefined but seems like when clientMismatch was added we never run this. It will be a lot manual work to revert them, and they are not causing any harm.
…endly-when-refresh-token-does-not-exist
…endly-when-refresh-token-does-not-exist
…endly-when-refresh-token-does-not-exist
nikosdouvlis
deleted the
elef/user-213-make-error-user-friendly-when-refresh-token-does-not-exist
branch
Description
Before
Now, when user needs to reauthorize/reconnect
Unify the errors for reauthorization vs attempting to create a new external account for the user. UX-wise the user will have to take the same action in order to recover, so we should not overwhelm them with information that is clearly more useful to developers than end users
and on mobile
Now, not recoverable state
If an error indicate that the user cannot recover, only then show the text in red. Without the "requires action" badge
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change