Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-expo)!: React Native >= 0.73 and Expo Web support #3456

Merged
merged 61 commits into from
Jul 26, 2024

Conversation

octoper
Copy link
Member

@octoper octoper commented May 28, 2024

Description

This PR introduces a new major release of the @clerk/clerk-expo SDK.

Breaking changes

This release will require to have at least react-native >= 0.73, we are trying to be more consistent on which versions of React Native and Expo we support from now on.

Features

This release will also add a couple features:

  • Web support
  • Prebuilt components for Web exported from /web subpath

Exported Components from /web subpath:

  • <SignIn/>
  • <SignUp/>
  • <UserProfile/>
  • <OrganizationSwitcher/>
  • <OrganizationProfile/>
  • <OrganizationList/>
  • <CreateOrganization/>
  • <SignInButton/>
  • <SignUpButton/>
  • <SignOutButton/>
  • <SignInWithMetamaskButton/>
  • <GoogleOneTap/>

Internal

The structure of @clerk/clerk-expo SDK has changes in order for us to support Native and Web platforms

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented May 28, 2024

🦋 Changeset detected

Latest commit: 156c736

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/clerk-expo Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper octoper force-pushed the vaggelis/expo-web-support branch from f80490a to bc6fcc1 Compare May 28, 2024 18:58
@octoper
Copy link
Member Author

octoper commented May 28, 2024

!snapshot

1 similar comment
@octoper
Copy link
Member Author

octoper commented May 28, 2024

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @octoper - the snapshot version command generated the following package versions:

Package Version
@clerk/clerk-expo 1.2.0-snapshot.v0f4c367
gatsby-plugin-clerk 5.0.0-beta.45

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

gatsby-plugin-clerk

npm i [email protected] --save-exact

@octoper
Copy link
Member Author

octoper commented May 28, 2024

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @octoper - the snapshot version command generated the following package versions:

Package Version
@clerk/clerk-expo 1.2.0-snapshot.v25f6d6e
gatsby-plugin-clerk 5.0.0-beta.45

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

gatsby-plugin-clerk

npm i [email protected] --save-exact

@octoper octoper force-pushed the vaggelis/expo-web-support branch from 92ce783 to c6bf6bb Compare May 30, 2024 11:01
@octoper octoper self-assigned this Jun 3, 2024
@octoper octoper force-pushed the vaggelis/expo-web-support branch 2 times, most recently from 65cc268 to b2520e7 Compare June 12, 2024 11:57
@octoper octoper force-pushed the vaggelis/expo-web-support branch 3 times, most recently from 933f0ad to dbd23e9 Compare June 28, 2024 11:04
@octoper octoper force-pushed the vaggelis/expo-web-support branch from 2bf5630 to 65afad4 Compare July 2, 2024 13:54
@octoper octoper force-pushed the vaggelis/expo-web-support branch 2 times, most recently from 83feaba to d8fdaee Compare July 4, 2024 14:30
@octoper octoper force-pushed the vaggelis/expo-web-support branch 3 times, most recently from bfdf03d to a3c6a5f Compare July 8, 2024 10:05
@octoper
Copy link
Member Author

octoper commented Jul 8, 2024

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @octoper - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 0.0.2-snapshot.va3c6a5f
@clerk/clerk-expo 1.3.0-snapshot.va3c6a5f
gatsby-plugin-clerk 5.0.0-beta.45
@clerk/testing 1.1.10-snapshot.va3c6a5f

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

gatsby-plugin-clerk

npm i [email protected] --save-exact

@clerk/testing

npm i @clerk/[email protected] --save-exact

@octoper octoper force-pushed the vaggelis/expo-web-support branch from 6ff04fd to da60bc7 Compare July 9, 2024 12:28
@octoper
Copy link
Member Author

octoper commented Jul 9, 2024

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @octoper - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 0.0.2-snapshot.vda60bc7
@clerk/clerk-expo 1.3.0-snapshot.vda60bc7
gatsby-plugin-clerk 5.0.0-beta.45
@clerk/testing 1.1.10-snapshot.vda60bc7

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

gatsby-plugin-clerk

npm i [email protected] --save-exact

@clerk/testing

npm i @clerk/[email protected] --save-exact

@octoper octoper force-pushed the vaggelis/expo-web-support branch from da60bc7 to f219484 Compare July 9, 2024 12:51
@octoper
Copy link
Member Author

octoper commented Jul 9, 2024

!snapshot

@octoper octoper force-pushed the vaggelis/expo-web-support branch from 63c1d57 to c216d72 Compare July 24, 2024 09:00
packages/expo/package.json Outdated Show resolved Hide resolved
packages/expo/package.json Outdated Show resolved Hide resolved
Comment on lines 4 to 5
export const clerk = globalThis?.window?.Clerk;
export const getClerkInstance = globalThis?.window?.Clerk;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should clear this up ☝️

packages/expo/src/web/uiComponents.tsx Outdated Show resolved Hide resolved
@octoper octoper requested a review from LekoArts July 24, 2024 12:50
@octoper octoper requested a review from panteliselef July 25, 2024 09:06
@octoper
Copy link
Member Author

octoper commented Jul 25, 2024

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @octoper - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 1.0.3-snapshot.vc45c61c
@clerk/backend 1.4.2-snapshot.vc45c61c
@clerk/elements 0.10.6-snapshot.vc45c61c
@clerk/clerk-expo 2.0.0-snapshot.vc45c61c
@clerk/express 0.0.20-snapshot.vc45c61c
@clerk/fastify 1.0.22-snapshot.vc45c61c
gatsby-plugin-clerk 5.0.0-beta.45
@clerk/nextjs 5.2.7-snapshot.vc45c61c
@clerk/remix 4.2.6-snapshot.vc45c61c
@clerk/clerk-sdk-node 5.0.19-snapshot.vc45c61c
@clerk/tanstack-start 0.1.10-snapshot.vc45c61c
@clerk/testing 1.2.2-snapshot.vc45c61c

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/[email protected] --save-exact

@clerk/backend

npm i @clerk/[email protected] --save-exact

@clerk/elements

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@clerk/express

npm i @clerk/[email protected] --save-exact

@clerk/fastify

npm i @clerk/[email protected] --save-exact

gatsby-plugin-clerk

npm i [email protected] --save-exact

@clerk/nextjs

npm i @clerk/[email protected] --save-exact

@clerk/remix

npm i @clerk/[email protected] --save-exact

@clerk/clerk-sdk-node

npm i @clerk/[email protected] --save-exact

@clerk/tanstack-start

npm i @clerk/[email protected] --save-exact

@clerk/testing

npm i @clerk/[email protected] --save-exact

@octoper
Copy link
Member Author

octoper commented Jul 25, 2024

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @octoper - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 1.0.3-snapshot.v999ed09
@clerk/backend 1.4.2-snapshot.v999ed09
@clerk/elements 0.10.6-snapshot.v999ed09
@clerk/clerk-expo 2.0.0-snapshot.v999ed09
@clerk/express 0.0.20-snapshot.v999ed09
@clerk/fastify 1.0.22-snapshot.v999ed09
gatsby-plugin-clerk 5.0.0-beta.45
@clerk/nextjs 5.2.7-snapshot.v999ed09
@clerk/remix 4.2.6-snapshot.v999ed09
@clerk/clerk-sdk-node 5.0.19-snapshot.v999ed09
@clerk/tanstack-start 0.1.10-snapshot.v999ed09
@clerk/testing 1.2.2-snapshot.v999ed09

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/[email protected] --save-exact

@clerk/backend

npm i @clerk/[email protected] --save-exact

@clerk/elements

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@clerk/express

npm i @clerk/[email protected] --save-exact

@clerk/fastify

npm i @clerk/[email protected] --save-exact

gatsby-plugin-clerk

npm i [email protected] --save-exact

@clerk/nextjs

npm i @clerk/[email protected] --save-exact

@clerk/remix

npm i @clerk/[email protected] --save-exact

@clerk/clerk-sdk-node

npm i @clerk/[email protected] --save-exact

@clerk/tanstack-start

npm i @clerk/[email protected] --save-exact

@clerk/testing

npm i @clerk/[email protected] --save-exact

@octoper octoper merged commit 3a904e8 into main Jul 26, 2024
18 checks passed
@octoper octoper deleted the vaggelis/expo-web-support branch July 26, 2024 07:59
BRKalow pushed a commit that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants