feat(elements): Introduce exampleMode prop on Root components #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7bf0ed7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brkalow
commented
Apr 12, 2024
Comment on lines
+34
to
+44
| const evt: SignUpRouterInitEvent = { | ||
| type: 'INIT', | ||
| clerk, | ||
| router, | ||
| signInPath: SIGN_IN_DEFAULT_BASE_PATH, | ||
| exampleMode, | ||
| }; | ||
|
|
||
| if (ref.getSnapshot().can(evt)) { | ||
| ref.send(evt); | ||
| } | ||
| }, [clerk, router]); | ||
| if (ref.getSnapshot().can(evt)) { | ||
| ref.send(evt); | ||
| } |
There was a problem hiding this comment.
It made more sense to just put the init event inside the loaded callback, instead of introducing the new event. This fixed a bug where the init event wasn't applying if clerk loaded first.
tmilewski
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce
exampleMode, which unconditionally renders the start step. In the future, we can leverage this to make "mock" functional flows in docs. We'll use this currently in the docs to showcase pre-built examples.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change