feat(clerk-js,types): Add protect to billing components #3179
Conversation
|
| @@ -17,6 +17,7 @@ type BillingProviderValue = { | |||
| currentPage: BillingPages; | |||
| goToPlanAndBilling: () => void; | |||
| goToManageBillingPlan: () => void; | |||
| checkPermissions?: boolean; | |||
| @@ -17,6 +17,7 @@ type BillingProviderValue = { | |||
| currentPage: BillingPages; | |||
| goToPlanAndBilling: () => void; | |||
| goToManageBillingPlan: () => void; | |||
| checkPermissions?: boolean; | |||
There was a problem hiding this comment.
I imagine that this is needed to us to support Billing inside the UserProfile where permissions do not exist, right ?
There was a problem hiding this comment.
Correct @panteliselef
| {checkPermissions ? ( | ||
| <Protect permission='org:sys_billing:manage'> |
There was a problem hiding this comment.
Maybe using useProtect makes more sense now that we have checkPermissions
* feat(clerk-js,types): Add protect to billing components * fix(clerk-js): Check permissions only in organization billing
Description
In this pr we are adding protect to billing components
⚠️ merge this pr after fapi/dapi introduce
org:sys_billing:read&org:sys_billing:readChecklist
npm testruns as expected.npm run buildruns as expected.Type of change