fix(clerk-js): Align <OrganizationProfile/> with designs #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a91f12a The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!preview |
|
Hey @octoper, your preview is available.
|
octoper
force-pushed
the
vaggelis/sdk-1214-pixel-perfect-organizationprofile
branch
2 times, most recently
from
33f9ffc to
dee1e11
Compare
|
!preview |
desiprisg
reviewed
Jan 17, 2024
| <ProfileSection.Item id='organizationProfile'> | ||
| <ProfileSection.Item | ||
| id='organizationProfile' | ||
| sx={t => ({ maxHeight: t.space.$8 })} |
There was a problem hiding this comment.
This is mainly to avoid having Organization Profile text centered, as it solves the layout shift when the action card is open, and also it's a bit closer to the design.
packages/clerk-js/src/ui/components/OrganizationProfile/OrganizationMembersTabInvitations.tsx
Outdated
Show resolved
Hide resolved
octoper
force-pushed
the
vaggelis/sdk-1214-pixel-perfect-organizationprofile
branch
from
10b3411 to
dba7382
Compare
|
!preview |
anagstef
approved these changes
Jan 17, 2024
octoper
force-pushed
the
vaggelis/sdk-1214-pixel-perfect-organizationprofile
branch
from
dba7382 to
bbadfec
Compare
|
!preview |
anagstef
deleted the
vaggelis/sdk-1214-pixel-perfect-organizationprofile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore