Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clerk-js): Minor UI tweaks #2446

Merged
merged 8 commits into from
Dec 22, 2023
Merged

Conversation

octoper
Copy link
Member

@octoper octoper commented Dec 22, 2023

Description

This PR include a lot of minor UI tweaks for the re-theme of the components:

  • <SIgnUp/> ,<SignIn/> lot's of improvements to match the designs and look better on mobile devices
  • Phone input improvements
  • Input error improvements
  • Added danger variant for Alert component
  • Fixed keyboard navigation for when picking members role

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

Copy link

changeset-bot bot commented Dec 22, 2023

🦋 Changeset detected

Latest commit: 5f4d1b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper octoper force-pushed the vaggelis/signup-retheme-minor-tweaks branch from 602d5f0 to eb1c716 Compare December 22, 2023 21:02
@octoper octoper marked this pull request as ready for review December 22, 2023 22:25
@octoper octoper force-pushed the vaggelis/signup-retheme-minor-tweaks branch from 3903992 to 5f4d1b3 Compare December 22, 2023 22:25
@octoper
Copy link
Member Author

octoper commented Dec 22, 2023

!preview

@clerk-cookie
Copy link
Collaborator

clerk-cookie commented Dec 22, 2023

Hey @octoper, your preview is available.

Status Preview Updated (UTC)
🍪 Deployed Visit preview Dec 22, 2023 10:32 PM

@octoper octoper requested a review from anagstef December 22, 2023 22:36
@octoper octoper self-assigned this Dec 22, 2023
@octoper octoper requested a review from a team December 22, 2023 22:36
@anagstef anagstef added this pull request to the merge queue Dec 22, 2023
Merged via the queue into main with commit a68a673 Dec 22, 2023
7 checks passed
@anagstef anagstef deleted the vaggelis/signup-retheme-minor-tweaks branch December 22, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants