Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js): Form.PhoneNumber and Form.OTPInput #2201

Merged
merged 7 commits into from
Nov 25, 2023

Conversation

panteliselef
Copy link
Member

@panteliselef panteliselef commented Nov 23, 2023

Description

This PR

  • replaces <Form.Control type='tel' with <Form.PhoneNumber/>
  • replaces <CodeForm/> and its duplicate logic with <Form.OTPInput/> and useFieldOTP

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@panteliselef panteliselef requested a review from a team November 23, 2023 17:49
@panteliselef panteliselef self-assigned this Nov 23, 2023
Copy link

changeset-bot bot commented Nov 23, 2023

🦋 Changeset detected

Latest commit: 3ef4162

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef panteliselef marked this pull request as ready for review November 24, 2023 09:20
@panteliselef panteliselef force-pushed the elef/sdk-674-otp-phone branch from 4758eb4 to 3ef4162 Compare November 24, 2023 09:41
@panteliselef panteliselef changed the title feat(clerk-js): Form.PhoneNumber and Form.OTP feat(clerk-js): Form.PhoneNumber and Form.OTPInput Nov 25, 2023
@panteliselef panteliselef added this pull request to the merge queue Nov 25, 2023
Merged via the queue into main with commit 63713c3 Nov 25, 2023
7 checks passed
@panteliselef panteliselef deleted the elef/sdk-674-otp-phone branch November 25, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants