-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Retheme <SignIn /> (part 1) #2179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1c4bd45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marcelscruz
requested review from
panteliselef,
anagstef and
desiprisg
and removed request for
panteliselef
December 12, 2023 14:46
marcelscruz
changed the title
[WIP] Retheme <SignIn />
[WIP] Retheme <SignIn /> (part 1)
Dec 12, 2023
anagstef
reviewed
Dec 12, 2023
anagstef
approved these changes
Dec 12, 2023
octoper
pushed a commit
that referenced
this pull request
Dec 13, 2023
* feat(clerk-js): Add new design on sign-in initial card * feat(clerk-js): Add new design on TOTP card * fix(clerk-js): Wrong import and wrong icon style * feat(clerk-js): Add fake continue on TOTP * chore(clerk-js): Delete unused OTPInputLabel and OTPInputDescription * chore(clerk-js): Re-add styles on card footer, submit button and identify preview * feat(clerk-js): Add new design on alternative methods * chore(clerk-js): Remove old back link from card header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes a partial redesign of the
<SignIn>
component.Descriptors:
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change
Packages affected
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/clerk-expo
@clerk/fastify
gatsby-plugin-clerk
@clerk/localizations
@clerk/nextjs
@clerk/clerk-react
@clerk/remix
@clerk/clerk-sdk-node
@clerk/shared
@clerk/themes
@clerk/types
build/tooling/chore