Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(remix): Drop deprecations #2022

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Conversation

dimkl
Copy link
Contributor

@dimkl dimkl commented Nov 3, 2023

Description

Drop deprecations. Migration steps:

  • use CLERK_SECRET_KEY instead of CLERK_API_KEY env variable
  • use secretKey instead of apiKey
  • use CLERK_PUBLISHABLE_KEY instead of CLERK_FRONTEND_API env variable
  • use publishableKey instead of frontendApi

Extra:

  • refactor to use isDevelopmentFromApiKey from @clerk/shared

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@dimkl dimkl self-assigned this Nov 3, 2023
@dimkl dimkl requested a review from a team as a code owner November 3, 2023 01:30
Copy link

changeset-bot bot commented Nov 3, 2023

🦋 Changeset detected

Latest commit: 02f88ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/remix Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimkl dimkl force-pushed the sdk-782-drop-deprecations-remix branch from 9c04802 to 02f88ca Compare November 3, 2023 01:38
@dimkl dimkl added this pull request to the merge queue Nov 3, 2023
Merged via the queue into main with commit c08f804 Nov 3, 2023
7 checks passed
@dimkl dimkl deleted the sdk-782-drop-deprecations-remix branch November 3, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants