-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(clerk-sdk-node): Drop deprecations #2021
Conversation
🦋 Changeset detectedLatest commit: 8148ca3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Blocked by #2006 |
ae6352e
to
56b4880
Compare
packages/sdk-node/package.json
Outdated
], | ||
"scripts": { | ||
"build": "npm run clean && tsup", | ||
"postbuild": "node ../../scripts/subpath-workaround.mjs sdk-node", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dimkl probably i'm missing some context, but why do we need this ? feel free to point me to an internal document if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will generate a packages/sdk-node/instance/
folder with a package.json
to be used for subpath import of @clerk/clerk-sdk-node/instance
. We have used it in @clerk/shared
.
56b4880
to
7f9ed77
Compare
1431f76
to
7abf631
Compare
7abf631
to
6abb21b
Compare
The dropped setters: `setClerkApiVersion`, `setClerkHttpOptions`, `setClerkServerApiUrl`
6abb21b
to
96a48a0
Compare
96a48a0
to
915c067
Compare
Changes: - drop subpath exports of /esm|cjs/instance
915c067
to
8148ca3
Compare
Dismissing the "request changes" review as it's blocking Dimitris. I've confirmed that the requested changes have been made.
Description
Drop deprecations. Migration steps:
CLERK_SECRET_KEY
instead ofCLERK_API_KEY
env variablesecretKey
instead ofapiKey
CLERK_PUBLISHABLE_KEY
instead ofCLERK_FRONTEND_API
env variablepublishableKey
instead offrontendApi
createClerkClient
with options to create a new clerkClient instead of usingthe following setters:
setClerkApiVersion
setClerkHttpOptions
setClerkServerApiUrl
setClerkApiKey
@clerk/clerk-sdk-node
instead of@clerk/clerk-sdk-node/{cjs|esm}/instance
Extra:
Depends on the following PRs because of re-exports:
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change
Packages affected
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/clerk-expo
@clerk/fastify
gatsby-plugin-clerk
@clerk/localizations
@clerk/nextjs
@clerk/clerk-react
@clerk/remix
@clerk/clerk-sdk-node
@clerk/shared
@clerk/themes
@clerk/types
build/tooling/chore