Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Import deprecatedObjectProperty from subpath #1997

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

panteliselef
Copy link
Member

Description

This PR fixes an issue with imports & subpaths.

It also casts authStatus in order the pre-commit hooks to allow for the commit.

This needs to only be merged to v4, because this code was previously only merged to v4.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

Copy link

changeset-bot bot commented Nov 1, 2023

🦋 Changeset detected

Latest commit: bb391a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef panteliselef self-assigned this Nov 1, 2023
Copy link
Contributor

@dimkl dimkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Was there an issue

@panteliselef
Copy link
Member Author

nice! Was there an issue

Quote from @LekoArts

We can help bundlers/Node to decide what to parse, load, analyze, and bundle by defining module subpaths.
PR from @LekoArts

@LekoArts LekoArts merged commit ca05bb0 into main-v4 Nov 1, 2023
12 of 17 checks passed
@LekoArts LekoArts deleted the elef/fix-SDK-696-deprecate-resources-v4 branch November 1, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants