test(clerk-js): Clean up act() errors #1990
Conversation
🦋 Changeset detectedLatest commit: bc50696 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
changed the title
.changeset/pretty-mice-share.md
Outdated
| '@clerk/clerk-js': patch | ||
| --- | ||
|
|
||
| Internal cleanup from errors in console regarding `act()`. |
There was a problem hiding this comment.
Users wouldn't really care about that, but you changed some functionality in the component that people use. Maybe explain that instead?
There was a problem hiding this comment.
@LekoArts Customers are not affected by the other change either, i'm converting this to an empty changeset
| @@ -263,15 +264,15 @@ export const FormFeedback = (props: FormFeedbackProps) => { | |||
| export const FormControl = forwardRef<HTMLInputElement, PropsWithChildren<FormControlProps>>((props, ref) => { | |||
| const { t } = useLocalizations(); | |||
| const card = useCardState(); | |||
| const [isFocused, setIsFocused] = useState(false); | |||
| // const [isFocused, setIsFocused] = useState(false); | |||
There was a problem hiding this comment.
Let's remove this dead code completely if not needed anymore
panteliselef
force-pushed
the
elef/SDK-856-act-errors
branch
from
b64e8cf to
bc50696
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Description
This PR removes console errors regarding the usage of
act()while tests are running.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore