Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Stop ts errors for non-static nextjs typed routes in authMiddleware #1928

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(nextjs): Stop ts errors for non-static nextjs typed routes in aut…
…hMiddleware
desiprisg committed Oct 23, 2023
commit 9a1f767c40b431427bb9df1a9a91dfd95954b1bf
5 changes: 5 additions & 0 deletions .changeset/curly-ties-mix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/nextjs': patch
---

Fix an issue where only static routes would be allowed by `publicRoutes` prop from `authMiddleware`.
4 changes: 3 additions & 1 deletion packages/nextjs/src/server/authMiddleware.ts
Original file line number Diff line number Diff line change
@@ -39,7 +39,9 @@ type ExcludeRootPath<T> = T extends '/' ? never : T;
type RouteMatcherWithNextTypedRoutes =
| WithPathPatternWildcard<ExcludeRootPath<NextTypedRoute>>
| NextTypedRoute
| (string & object);
// This is necessary to allow all string, using something other than `{}` here WILL break types!
// eslint-disable-next-line @typescript-eslint/ban-types
| (string & {});

const INFINITE_REDIRECTION_LOOP_COOKIE = '__clerk_redirection_loop';