chore(repo): Introduce integration test for vite with sdk-node #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dimkl
force-pushed
the
js-509-add-vite-clerk-sdk-node-test
branch
from
3bb7dc0 to
dba7225
Compare
LekoArts
reviewed
Oct 20, 2023
LekoArts
reviewed
Oct 20, 2023
dimkl
force-pushed
the
js-509-add-vite-clerk-sdk-node-test
branch
from
dba7225 to
d5ff6c6
Compare
dimkl
changed the title
dimkl
force-pushed
the
js-509-add-vite-clerk-sdk-node-test
branch
from
d5ff6c6 to
361dc31
Compare
dimkl
force-pushed
the
js-509-add-vite-clerk-sdk-node-test
branch
from
361dc31 to
9f6e819
Compare
dimkl
force-pushed
the
js-509-add-vite-clerk-sdk-node-test
branch
4 times, most recently
from
f96d40a to
9f5e433
Compare
dimkl
commented
Nov 7, 2023
| } else { | ||
| // since we have moved the integrations outside the monorepo we should fallback to * in case | ||
| // of empty version for non Clerk packages (eg next should install the latest version) | ||
| dependencies.set(name, '*'); | ||
| } |
There was a problem hiding this comment.
@nikosdouvlis PTAL this changes as it affect what version we expect to use in our integration tests.
There was a problem hiding this comment.
I replaced this change with the following actions:
- drop default
*version - move the logic to link our packages to local folders in the presets to avoid polluting the
ApplicationConfigmodel with Clerk-specific logic.
cc: @nikosdouvlis
dimkl
force-pushed
the
js-509-add-vite-clerk-sdk-node-test
branch
from
9f5e433 to
2a11c7e
Compare
dimkl
force-pushed
the
js-509-add-vite-clerk-sdk-node-test
branch
3 times, most recently
from
294d4b8 to
3232bc4
Compare
This change will help us avoid accidentally using top-level node_modules/ from the current monorepo and will allow us to run tests isolated from the monorepo related dependencies. We had to use a folder outside the monorepo for the integration tests to avoid having the npm module resolution algorithm find unrelated dependencies.
dimkl
force-pushed
the
js-509-add-vite-clerk-sdk-node-test
branch
from
3232bc4 to
d8f6a05
Compare
nikosdouvlis
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add integration test to verify that
@clerk/sharedtree-shaking works in backend application that do not usereactas dependency.We have introduced an Express + Vite template application that uses
@clerk/clerk-sdk-nodewith the following endpoints/api/protectedendpoint that usesexpressRequireAuth()from@clerk/clerk-sdk-nodeto verify authentication/sign-inrenders HTML that mounts<SignIn/>client-side component using ClerkJS/sign-uprenders HTML that mounts<SignUp/>client-side component using ClerkJS/protectedrenders HTMLSignedInorSignedOutcontext and makes a request to the/api/protectedto fetch the response that will be appended in body and asserted via playwright.#1883
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore