Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clerk-js): Enforce LTR direction in code inputs #1873

Conversation

desiprisg
Copy link
Contributor

@desiprisg desiprisg commented Oct 12, 2023

Description

Before:
Screenshot 2023-10-12 at 15 03 03

After:
Screenshot 2023-10-12 at 15 02 29

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@desiprisg desiprisg requested a review from a team as a code owner October 12, 2023 11:58
@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2023

🦋 Changeset detected

Latest commit: d3b5252

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimkl
Copy link
Contributor

dimkl commented Oct 12, 2023

@desiprisg Could you add a screenshot with before/after the fix?

@desiprisg
Copy link
Contributor Author

@desiprisg Could you add a screenshot with before/after the fix?

done

Copy link
Member

@anagstef anagstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Should we also fix this padding here?

Screenshot 2023-10-12 at 15 08 39

@LekoArts LekoArts added this pull request to the merge queue Oct 13, 2023
Merged via the queue into main with commit e67fcfe Oct 13, 2023
5 checks passed
@LekoArts LekoArts deleted the george/usr-410-codenumber-are-rtl-in-component-when-using-rtl-language branch October 13, 2023 06:36
@clerk-cookie clerk-cookie mentioned this pull request Oct 13, 2023
@clerk-cookie
Copy link
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants