-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clerk-js): Improve password error feedback animations #1776
feat(clerk-js): Improve password error feedback animations #1776
Conversation
🦋 Changeset detectedLatest commit: 26ef242 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1fd9157
to
b6c7cbd
Compare
@desiprisg can you please add a description and a couple of screenshots if needed? |
3d5378e
to
16386f3
Compare
a053296
to
8d9d71a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nothing blocking, just some questions and observations.
55cf3b0
to
b629fd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ship this !!
acef2d5
to
1ae3414
Compare
feat(clerk-js): Add PasswordInput validation debouncing refactor(clerk-js): Remove unused props fix(clerk-js): Add infoText for VerifyDomainPage fix(clerk-js): Smooth error animation and min height
test(clerk-js): Fix tests for password validation chore(clerk-js): Changeset chore(clerk-js): Improve changeset fix(clerk-js): Address PR comments refactor(clerk-js): Avoid useEffect usage for feedbacks and maxHeight fix(clerk-js): Add clearFeedback to types fix(clerk-js): Delay feedback after focus/blur on input elements
chore(clerk-js): Replace NodeJS.Timeout type refactor(clerk-js): Extract inAnimation ternary into variable refactor(clerk-js): Handle the undefined case in getElementProps
d14134d
to
26ef242
Compare
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
This PR aims to refactor the form error animations and some internal methods. It also adds debouncing to the password validation, along with some small changes to the types of feedback shown based on the different conditions.
Screen.Recording.2023-09-28.at.19.30.00.mov
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change
Packages affected
@clerk/clerk-js
@clerk/clerk-react
@clerk/nextjs
@clerk/remix
@clerk/types
@clerk/themes
@clerk/localizations
@clerk/clerk-expo
@clerk/backend
@clerk/clerk-sdk-node
@clerk/shared
@clerk/fastify
@clerk/chrome-extension
gatsby-plugin-clerk
build/tooling/chore