Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tanstack-start): Merge router context instead of updating #4425

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

octoper
Copy link
Member

@octoper octoper commented Oct 29, 2024

Description

This PR fixes bug where the initialisation of Clerk overwrites the context, by merging the original/existing context with the clerkInitialState.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Oct 29, 2024

🦋 Changeset detected

Latest commit: 0cdac8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/tanstack-start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper octoper marked this pull request as ready for review October 29, 2024 21:53
@octoper octoper force-pushed the vaggelis.fix/merge-initial-context branch from 9655f31 to f39421c Compare October 29, 2024 21:53
@octoper
Copy link
Member Author

octoper commented Oct 29, 2024

!snapshot

Copy link
Member

@wobsoriano wobsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@clerk-cookie
Copy link
Collaborator

Hey @octoper - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 1.4.2-snapshot.v0cdac8a
@clerk/backend 1.15.2-snapshot.v0cdac8a
@clerk/chrome-extension 1.3.24-snapshot.v0cdac8a
@clerk/clerk-js 5.30.0-snapshot.v0cdac8a
@clerk/elements 0.17.2-snapshot.v0cdac8a
@clerk/clerk-expo 2.2.30-snapshot.v0cdac8a
@clerk/express 1.3.4-snapshot.v0cdac8a
@clerk/fastify 2.0.6-snapshot.v0cdac8a
@clerk/localizations 3.4.1-snapshot.v0cdac8a
@clerk/nextjs 6.0.3-snapshot.v0cdac8a
@clerk/clerk-react 5.13.2-snapshot.v0cdac8a
@clerk/remix 4.2.42-snapshot.v0cdac8a
@clerk/clerk-sdk-node 5.0.55-snapshot.v0cdac8a
@clerk/shared 2.10.2-snapshot.v0cdac8a
@clerk/tanstack-start 0.4.18-snapshot.v0cdac8a
@clerk/testing 1.3.16-snapshot.v0cdac8a
@clerk/themes 2.1.40-snapshot.v0cdac8a
@clerk/types 4.29.0-snapshot.v0cdac8a
@clerk/ui 0.1.11-snapshot.v0cdac8a
@clerk/upgrade 1.2.0-snapshot.v0cdac8a

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/[email protected] --save-exact

@clerk/backend

npm i @clerk/[email protected] --save-exact

@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/elements

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@clerk/express

npm i @clerk/[email protected] --save-exact

@clerk/fastify

npm i @clerk/[email protected] --save-exact

@clerk/localizations

npm i @clerk/[email protected] --save-exact

@clerk/nextjs

npm i @clerk/[email protected] --save-exact

@clerk/clerk-react

npm i @clerk/[email protected] --save-exact

@clerk/remix

npm i @clerk/[email protected] --save-exact

@clerk/clerk-sdk-node

npm i @clerk/[email protected] --save-exact

@clerk/shared

npm i @clerk/[email protected] --save-exact

@clerk/tanstack-start

npm i @clerk/[email protected] --save-exact

@clerk/testing

npm i @clerk/[email protected] --save-exact

@clerk/themes

npm i @clerk/[email protected] --save-exact

@clerk/types

npm i @clerk/[email protected] --save-exact

@clerk/ui

npm i @clerk/[email protected] --save-exact

@clerk/upgrade

npm i @clerk/[email protected] --save-exact

@LekoArts LekoArts merged commit 915b257 into main Oct 30, 2024
22 checks passed
@LekoArts LekoArts deleted the vaggelis.fix/merge-initial-context branch October 30, 2024 09:23
octoper added a commit that referenced this pull request Oct 30, 2024
@kaandok
Copy link

kaandok commented Dec 23, 2024

@octoper why was this reverted? it's causing the loaders to run twice as mentioned here: #4414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants