Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js,types,backend): Use EIP-4361 message spec for Web3 wallets #4334

Conversation

chanioxaris
Copy link
Member

@chanioxaris chanioxaris commented Oct 15, 2024

Description

In this commit we are updating our Web3 flows logic to use the new 'message' property of a Web3 verification, which follows the EIP-4361 spec, to sign a new request. This message format provides a better experience to the end user by let them know additional information for the application they are about to use

Before

376635904-1f3c2d75-da1a-46be-a1ad-612ebd2f4e82

After

376625878-7ec1f072-3e1f-4788-bf13-6db6636332f7

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Oct 15, 2024

🦋 Changeset detected

Latest commit: b6fb07f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@clerk/clerk-js Minor
@clerk/backend Minor
@clerk/types Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/astro Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/elements Patch
@clerk/localizations Patch
@clerk/clerk-react Patch
@clerk/shared Patch
@clerk/themes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

In this commit we are updating our Web3 flows logic to use the new 'message' property of
a Web3 verification, which follows the EIP-4361 spec, to sign a new request. This message
format provides a better experience to the end user by let them know additional information
for the application they are about to use
@chanioxaris chanioxaris force-pushed the haris/user-686-adapt-the-sign-in-with-ethereum-eip-4361-message-spec branch from d1a40f7 to f4ebb99 Compare October 15, 2024 16:53
@chanioxaris chanioxaris requested a review from a team October 16, 2024 07:17
@chanioxaris chanioxaris marked this pull request as ready for review October 16, 2024 07:17
Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a link for the spec that you can add to the description ?

@chanioxaris
Copy link
Member Author

Is there a link for the spec that you can add to the description ?

Sure thing added!

@chanioxaris chanioxaris merged commit 2102052 into main Oct 16, 2024
23 checks passed
@chanioxaris chanioxaris deleted the haris/user-686-adapt-the-sign-in-with-ethereum-eip-4361-message-spec branch October 16, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants