-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend,shared,clerk-js): Support suffixed cookies [CORE-2086] #3506
Conversation
🦋 Changeset detectedLatest commit: 4b3e2e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
f12aaa0
to
7dcea49
Compare
7dcea49
to
50ca6e3
Compare
50ca6e3
to
6a7c065
Compare
6a7c065
to
976ae21
Compare
0655a51
to
da8dd2b
Compare
e05b4b2
to
c6335a2
Compare
548ebc5
to
2865b88
Compare
4c7d111
to
d871f0f
Compare
d871f0f
to
1192df8
Compare
# Conflicts: # integration/presets/envs.ts
# Conflicts: # .github/workflows/ci.yml
5399d0a
to
32b83ca
Compare
006eaf8
to
6e91c3b
Compare
fakeUsers.push(fakeUser); | ||
await u.services.users.createBapiUser(fakeUser); | ||
|
||
await u.po.signIn.goTo({ timeout: 30000 }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ We expect that in this case a handshake flow should be triggered since un-suffixed __client_uat
would have a a value > 0
integration/tests/sessions/root-subdomain-prod-instances.test.ts
Outdated
Show resolved
Hide resolved
98619e3
to
04fd57d
Compare
04fd57d
to
4b3e2e1
Compare
Closing this one manually as GH is partially down - the commit is already into main |
Co-authored-by: Nikos Douvlis <[email protected]>
Description
Generate suffixed and un-suffixed
__client_uat
(in dev instance),__session
,__clerk_db_jwt
(In dev instance) cookies from ClerkJS and support reading the either the suffixed or the un-suffixed cookies in the backend SDK using the__client_uat
&__session
cookies.New ClerkJS versions will generate both suffixed and un-suffixed cookies but the backend SDK will consume only 1 of those 2.
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change