Fix waitForAppUrl race condition

clerk · Jul 12, 2024 · 4c7d111 · 4c7d111
1 parent ad543f3
commit 4c7d111
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -130,7 +130,7 @@ jobs:
 
   integration-tests:
     name: Integration Tests
-    needs: formatting-linting
+#    needs: formatting-linting
     runs-on: ${{ vars.RUNNER_LARGE || 'ubuntu-latest-l' }}
     timeout-minutes: ${{ vars.TIMEOUT_MINUTES_LONG && fromJSON(vars.TIMEOUT_MINUTES_LONG) || 15 }}
 
@@ -191,11 +191,11 @@ jobs:
         if: ${{ steps.task-status.outputs.affected == '1' }}
         working-directory: ${{runner.temp}}
         run: mkdir clerk-js && cd clerk-js && npm init -y && npm install @clerk/clerk-js
-      
+
       - name: Copy components @clerk/astro
         if: ${{ matrix.test-name == 'astro' }}
         run: cd packages/astro && npm run copy:components
-      
+
       - name: Write all ENV certificates to files in integration/certs
         if: ${{ steps.task-status.outputs.affected == '1' }}
         uses: actions/github-script@v7

diff --git a/integration/playwright.config.ts b/integration/playwright.config.ts
@@ -8,7 +8,8 @@ import * as path from 'path';
 
 config({ path: path.resolve(__dirname, '.env.local') });
 
-const numAvailableWorkers = os.cpus().length - 1;
+const numAvailableWorkers = Math.floor(os.cpus().length / 2) + 1;
+console.log(`Running tests using ${numAvailableWorkers} workers`);
 
 export const common: PlaywrightTestConfig = {
   testDir: './tests',
@@ -18,7 +19,7 @@ export const common: PlaywrightTestConfig = {
   retries: process.env.CI ? 2 : 0,
   timeout: 90000,
   maxFailures: process.env.CI ? 1 : undefined,
-  workers: process.env.CI ? numAvailableWorkers : '50%',
+  workers: process.env.CI ? numAvailableWorkers : '70%',
   reporter: process.env.CI ? 'line' : 'list',
   use: {
     ignoreHTTPSErrors: true,