chore(repo): Prepend commit hash with a char in prereleaseTemp #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently found out that `npm` may incorrectly treat a part of the version as a number instead of a string when it only contains numeric characters. This can cause rare issues when a version only contain numeric characters and it begins with a leading `0`, as this `0` will be dropped when `npm` parses the version as a number. For example, if we release `4.61.1-staging.0175607` it will end up on `npm` as `4.61.1-staging.175607` In order to fix this, we simply prepend the verson with a non-numeric character
🦋 Changeset detectedLatest commit: b940d81 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
anagstef
approved these changes
Oct 16, 2023
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently found out that
npmmay incorrectly treat a part of the version as a number instead of a string when it only contains numeric characters.This can cause rare issues when a version only contain numeric characters and it begins with a leading
0, as this0will be dropped whennpmparses the version as a number.For example, if we release
4.61.1-staging.0175607it will end up onnpmas4.61.1-staging.175607In order to fix this, we simply prepend the verson with a non-numeric character
Description
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore