Skip to content

Commit

Permalink
chore(repo): Prepend commit hash with a char in prereleaseTemp (#1888)
Browse files Browse the repository at this point in the history
* chore(repo): Prepend commit hash with a char in prereleaseTemp

We recently found out that `npm` may incorrectly treat a part of the version as a number instead of a string when it only contains numeric characters.

This can cause rare issues when a version only contain numeric characters and it begins with a leading `0`, as this `0` will be dropped when `npm` parses the version as a number.

For example, if we release `4.61.1-staging.0175607` it will end up on `npm` as `4.61.1-staging.175607`

In order to fix this, we simply prepend the verson with a non-numeric character

* Create five-months-look.md
  • Loading branch information
nikosdouvlis authored Oct 16, 2023
1 parent 0175607 commit cc9c483
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .changeset/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"ignore": [],
"snapshot": {
"useCalculatedVersion": true,
"prereleaseTemplate": "{tag}.{commit}"
"prereleaseTemplate": "{tag}.v{commit}"
},
"___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
"onlyUpdatePeerDependentsWhenOutOfRange": true,
Expand Down
2 changes: 2 additions & 0 deletions .changeset/five-months-look.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---

0 comments on commit cc9c483

Please sign in to comment.