Skip to content

Commit

Permalink
fix(upgrade): Fix ignore value rendering in recap
Browse files Browse the repository at this point in the history
  • Loading branch information
jescalan committed Jan 8, 2024
1 parent 1a0b30a commit 9c4a1c9
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/upgrade/source/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import Scan from './scan.js';
import guessFrameworks from './util/guess-framework.js';
import getClerkMajorVersion from './util/get-clerk-version.js';

export default function App({ _fromVersion, _toVersion, _sdk, _dir = false, _ignore = '' }) {
export default function App({ _fromVersion, _toVersion, _sdk, _dir = false, _ignore = [] }) {
const [sdks, setSdks] = useState(_sdk ? [_sdk] : []);
const [sdkGuessAttempted, setSdkGuessAttempted] = useState(false);
const [fromVersion, setFromVersion] = useState(_fromVersion);
Expand Down Expand Up @@ -157,7 +157,7 @@ export default function App({ _fromVersion, _toVersion, _sdk, _dir = false, _ign
/>
</>
)}
{!isEmpty(sdks) && fromVersion && toVersion && dir && !ignore && (
{!isEmpty(sdks) && fromVersion && toVersion && dir && isEmpty(ignore) && !configComplete && (
<>
<Text>
Are there any files or directories you'd like to ignore? If so, you can add them below, separated by commas.
Expand All @@ -168,7 +168,7 @@ export default function App({ _fromVersion, _toVersion, _sdk, _dir = false, _ign
placeholder='docs/**, images/**'
defaultValue={ignore}
onSubmit={val => {
setIgnore(val.split(','));
setIgnore(val);
setConfigComplete(true);
}}
/>
Expand Down

0 comments on commit 9c4a1c9

Please sign in to comment.