fix(clerk-js): Clear feedback when undefined is passed to setError (

#2399) (#2409) We still have a lot of places in clerk-js where we call `setError(undefined)` instead of `clearFeedback` (cherry picked from commit bf09d18)
clerk · Dec 19, 2023 · 98f8ec6 · 98f8ec6
1 parent 4d5cae2
commit 98f8ec6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/.changeset/thick-doors-smile.md b/.changeset/thick-doors-smile.md
@@ -0,0 +1,5 @@
+---
+'@clerk/clerk-js': patch
+---
+
+Bug fix: Clear feedback of input field if `setError` is called with undefined.
diff --git a/packages/clerk-js/src/ui/utils/useFormControl.ts b/packages/clerk-js/src/ui/utils/useFormControl.ts
@@ -106,6 +106,8 @@ export const useFormControl = <Id extends string>(
   const setError: FormControlState['setError'] = error => {
     if (error) {
       setFeedback({ message: translateError(error), type: 'error' });
+    } else {
+      clearFeedback();
     }
   };
   const setSuccess: FormControlState['setSuccess'] = message => {