chore(repo): Add buildOutput property on Application instead of accep…

…ting a custom log
clerk · Oct 18, 2023 · 83f81fb · 83f81fb
1 parent 9ebce0a
commit 83f81fb
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/integration/models/application.ts b/integration/models/application.ts
@@ -16,6 +16,7 @@ export const application = (config: ApplicationConfig, appDirPath: string, appDi
   const now = Date.now();
   const stdoutFilePath = path.resolve(appDirPath, `e2e.${now}.log`);
   const stderrFilePath = path.resolve(appDirPath, `e2e.${now}.err.log`);
+  let buildOutput = '';
 
   const self = {
     name,
@@ -68,9 +69,18 @@ export const application = (config: ApplicationConfig, appDirPath: string, appDi
       state.serverUrl = serverUrl;
       return { port, serverUrl, pid: proc.pid };
     },
-    build: async ({ log }: { log?: (msg: string) => void } = {}) => {
-      const finalLog = log ?? logger.child({ prefix: 'build' }).info;
-      await run(scripts.build, { cwd: appDirPath, log: finalLog });
+    build: async () => {
+      const log = logger.child({ prefix: 'build' }).info;
+      await run(scripts.build, {
+        cwd: appDirPath,
+        log: (msg: string) => {
+          buildOutput += `\n${msg}`;
+          log(msg);
+        },
+      });
+    },
+    get buildOutput() {
+      return buildOutput;
     },
     serve: async (opts: { port?: number; manualStart?: boolean } = {}) => {
       const port = opts.port || (await getPort());

diff --git a/integration/tests/next-build.test.ts b/integration/tests/next-build.test.ts
@@ -51,7 +51,7 @@ export default function RootLayout({ children }: { children: React.ReactNode })
       .commit();
     await app.setup();
     await app.withEnv(appConfigs.envs.withEmailCodes);
-    await app.build({ log: msg => output.push(msg) });
+    await app.build();
   });
 
   test.afterAll(async () => {
@@ -65,7 +65,7 @@ export default function RootLayout({ children }: { children: React.ReactNode })
      * Using /_not-found as it is an internal page that should statically render by default.
      * This is a good indicator of whether or not the entire app has been opted-in to dynamic rendering.
      */
-    const notFoundPageLine = output.find(msg => msg.includes('/_not-found'));
+    const notFoundPageLine = app.buildOutput.split('\n').find(msg => msg.includes('/_not-found'));
 
     expect(notFoundPageLine).not.toContain(dynamicIndicator);
   });