Skip to content

Commit

Permalink
chore(clerk-expo-passkeys): fix breaking changes (#4601)
Browse files Browse the repository at this point in the history
  • Loading branch information
AlexNti authored Nov 20, 2024
1 parent dd237b0 commit 725b885
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 6 deletions.
6 changes: 6 additions & 0 deletions .changeset/fifty-cameras-tease.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@clerk/expo-passkeys': patch
'@clerk/clerk-expo': patch
---
- Replaced import { Buffer } from 'node:buffer' with import { Buffer } from 'buffer'.
- Moved @clerk/expo-passkeys to a devDependency in @clerk/clerk-expo.
8 changes: 8 additions & 0 deletions packages/expo-passkeys/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,12 @@ module.exports = {
settings: {
'import/ignore': ['node_modules/react-native/index\\.js$'],
},
rules: {
'no-restricted-imports': [
'error',
{
patterns: ['node:*'],
},
],
},
};
3 changes: 1 addition & 2 deletions packages/expo-passkeys/src/utils.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { Buffer } from 'node:buffer';

import { ClerkWebAuthnError } from '@clerk/shared/error';
import { Buffer } from 'buffer';
export { ClerkWebAuthnError };

export function encodeBase64(data: ArrayLike<number> | ArrayBufferLike) {
Expand Down
6 changes: 5 additions & 1 deletion packages/expo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@
"dependencies": {
"@clerk/clerk-js": "workspace:*",
"@clerk/clerk-react": "workspace:*",
"@clerk/expo-passkeys": "workspace:*",
"@clerk/shared": "workspace:*",
"@clerk/types": "workspace:*",
"base-64": "^1.0.0",
Expand All @@ -71,6 +70,7 @@
},
"devDependencies": {
"@clerk/eslint-config-custom": "workspace:*",
"@clerk/expo-passkeys": "workspace:*",
"@types/base-64": "^1.0.2",
"@types/node": "^20.11.24",
"@types/react": "18.3.12",
Expand All @@ -83,6 +83,7 @@
"typescript": "*"
},
"peerDependencies": {
"@clerk/expo-passkeys": ">=0.0.6",
"expo-auth-session": ">=5",
"expo-local-authentication": ">=13.5.0",
"expo-secure-store": ">=12.4.0",
Expand All @@ -92,6 +93,9 @@
"react-native": ">=0.73"
},
"peerDependenciesMeta": {
"@clerk/expo-passkeys": {
"optional": true
},
"expo-local-authentication": {
"optional": true
},
Expand Down
6 changes: 3 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 725b885

Please sign in to comment.