chore(clerk-js): Fix or temp disable ESLint issues

clerk · Oct 19, 2023 · 6086101 · 6086101
1 parent ad9e965
commit 6086101
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 3 deletions.
diff --git a/.changeset/empty-terms-scream.md b/.changeset/empty-terms-scream.md
@@ -0,0 +1,2 @@
+---
+---
diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
@@ -34,7 +34,7 @@ jobs:
         with:
           use-turbo-cache: 'true'
       - name: Run lint
-        run: npm run lint
+        run: npm run lint -- --output-logs=errors-only -- --quiet
 
   unit-tests:
     name: Run unit tests

diff --git a/packages/clerk-js/src/ui/components/OrganizationProfile/InviteMembersPage.tsx b/packages/clerk-js/src/ui/components/OrganizationProfile/InviteMembersPage.tsx
@@ -24,6 +24,7 @@ export const InviteMembersPage = withCardStateProvider(() => {
   const reachedOrganizationMemberLimit =
     !!__unstable_manageBillingMembersLimit &&
     runIfFunctionOrReturn(__unstable_manageBillingMembersLimit) <=
+      // eslint-disable-next-line @typescript-eslint/restrict-plus-operands
       organization.pendingInvitationsCount + organization.membersCount;
 
   return (

diff --git a/packages/clerk-js/src/ui/components/OrganizationProfile/MembershipWidget.tsx b/packages/clerk-js/src/ui/components/OrganizationProfile/MembershipWidget.tsx
@@ -14,6 +14,9 @@ export const MembershipWidget = () => {
     return null;
   }
 
+  // eslint-disable-next-line @typescript-eslint/restrict-plus-operands
+  const totalCount = organization?.membersCount + organization?.pendingInvitationsCount;
+
   return (
     <Flex
       sx={theme => ({
@@ -57,7 +60,7 @@ export const MembershipWidget = () => {
             color: t.colors.$blackAlpha600,
           })}
         >
-          {organization?.membersCount + organization?.pendingInvitationsCount} of{' '}
+          {totalCount} of{' '}
           {__unstable_manageBillingMembersLimit
             ? `${runIfFunctionOrReturn(__unstable_manageBillingMembersLimit)} members`
             : 'unlimited'}

diff --git a/packages/clerk-js/src/ui/components/OrganizationProfile/ProfileSettingsPage.tsx b/packages/clerk-js/src/ui/components/OrganizationProfile/ProfileSettingsPage.tsx
@@ -37,6 +37,7 @@ export const ProfileSettingsPage = withCardStateProvider(() => {
   const dataChanged = organization.name !== nameField.value || organization.slug !== slugField.value;
   const canSubmit = (dataChanged || avatarChanged) && !slugField.errorText;
 
+  // eslint-disable-next-line @typescript-eslint/require-await
   const onSubmit = async (e: React.FormEvent) => {
     e.preventDefault();
     return (dataChanged ? organization.update({ name: nameField.value, slug: slugField.value }) : Promise.resolve())

diff --git a/packages/clerk-js/src/ui/components/OrganizationSwitcher/OrganizationSwitcherTrigger.tsx b/packages/clerk-js/src/ui/components/OrganizationSwitcher/OrganizationSwitcherTrigger.tsx
@@ -85,6 +85,7 @@ const NotificationCountBadgeSwitcherTrigger = withGate(
     });
 
     const notificationCount =
+      // eslint-disable-next-line @typescript-eslint/restrict-plus-operands
       (userInvitations.count || 0) + (userSuggestions.count || 0) + (membershipRequests?.count || 0);
 
     return (

diff --git a/packages/clerk-js/src/ui/components/UserProfile/ConnectedAccountsPage.tsx b/packages/clerk-js/src/ui/components/UserProfile/ConnectedAccountsPage.tsx
@@ -51,7 +51,7 @@ const AddConnectedAccount = () => {
   const isModal = mode === 'modal';
 
   const enabledStrategies = strategies.filter(s => s.startsWith('oauth')) as OAuthStrategy[];
-  const connectedStrategies = user.verifiedExternalAccounts.map(a => 'oauth_' + a.provider) as OAuthStrategy[];
+  const connectedStrategies = user.verifiedExternalAccounts.map(a => `oauth_${a.provider}`) as OAuthStrategy[];
 
   const unconnectedStrategies = enabledStrategies.filter(provider => {
     return !connectedStrategies.includes(provider);

diff --git a/packages/clerk-js/src/ui/components/UserProfile/EmailPage.tsx b/packages/clerk-js/src/ui/components/UserProfile/EmailPage.tsx
@@ -37,6 +37,7 @@ export const EmailPage = withCardStateProvider(() => {
 
   const canSubmit = emailField.value.length > 1 && user.username !== emailField.value;
 
+  // eslint-disable-next-line @typescript-eslint/require-await
   const addEmail = async (e: React.FormEvent) => {
     e.preventDefault();
     return user

diff --git a/packages/clerk-js/src/ui/components/UserProfile/PhonePage.tsx b/packages/clerk-js/src/ui/components/UserProfile/PhonePage.tsx
@@ -62,6 +62,7 @@ export const AddPhone = (props: AddPhoneProps) => {
 
   const canSubmit = phoneField.value.length > 1 && user.username !== phoneField.value;
 
+  // eslint-disable-next-line @typescript-eslint/require-await
   const addPhone = async (e: React.FormEvent) => {
     e.preventDefault();
     return user

diff --git a/packages/clerk-js/src/ui/components/UserProfile/ProfilePage.tsx b/packages/clerk-js/src/ui/components/UserProfile/ProfilePage.tsx
@@ -51,6 +51,7 @@ export const ProfilePage = withCardStateProvider(() => {
 
   const nameEditDisabled = user.samlAccounts.some(sa => sa.active);
 
+  // eslint-disable-next-line @typescript-eslint/require-await
   const onSubmit = async (e: React.FormEvent) => {
     e.preventDefault();