Skip to content

Commit

Permalink
chore(clerk-js): Remove duplication of factor comparators (#2842)
Browse files Browse the repository at this point in the history
* chore(clerk-js): Remove duplication of factor comparators

* chore(clerk-js): Remove duplication of factor comparators
  • Loading branch information
panteliselef authored Feb 22, 2024
1 parent cbdfa91 commit 4291669
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 45 deletions.
2 changes: 2 additions & 0 deletions .changeset/clever-bananas-turn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---

This file was deleted.

2 changes: 1 addition & 1 deletion packages/clerk-js/src/ui/components/SignIn/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { titleize } from '@clerk/shared';
import type { PreferredSignInStrategy, SignInFactor, SignInResource, SignInStrategy } from '@clerk/types';

import { PREFERRED_SIGN_IN_STRATEGIES } from '../../common/constants';
import { otpPrefFactorComparator, passwordPrefFactorComparator } from './strategies/factorSortingUtils';
import { otpPrefFactorComparator, passwordPrefFactorComparator } from '../../utils/factorSorting';

const FONT_SIZE_STEP = 2;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {
allStrategiesButtonsComparator,
otpPrefFactorComparator,
passwordPrefFactorComparator,
} from './factorSortingUtils';
} from '../factorSorting';

describe('otpPrefFactorComparator(a,b)', function () {
it('sorts an array of factors based on the otp pref sorter', function () {
Expand Down

0 comments on commit 4291669

Please sign in to comment.