-
Notifications
You must be signed in to change notification settings - Fork 280
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(shared): Improve expo compat (#1950)
* fix(shared): Remove "module" from package.json * chore(repo): Add subpath workaround script * chore(shared): Add script to shared * Create wise-houses-shop.md * chore(*): Fix stuff * chore(repo): Improve script * chore(repo): Scripting * Update wise-houses-shop.md
- Loading branch information
Showing
5 changed files
with
107 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@clerk/shared": patch | ||
--- | ||
|
||
Improve compatibility with Expo |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
browser | ||
callWithRetry | ||
color | ||
cookie | ||
date | ||
deprecated | ||
error | ||
file | ||
globs | ||
handleValueOrFn | ||
isomorphicAtob | ||
keys | ||
loadScript | ||
localStorageBroadcastChannel | ||
poller | ||
proxy | ||
underscore | ||
url | ||
react |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
// This file is a helper for the "subpath-workaround.mjs" script | ||
// We have to polyfill our "exports" subpaths :cry: | ||
|
||
export const subpathNames = [ | ||
'browser', | ||
'callWithRetry', | ||
'color', | ||
'cookie', | ||
'date', | ||
'deprecated', | ||
'error', | ||
'file', | ||
'globs', | ||
'handleValueOrFn', | ||
'isomorphicAtob', | ||
'keys', | ||
'loadScript', | ||
'localStorageBroadcastChannel', | ||
'poller', | ||
'proxy', | ||
'underscore', | ||
'url', | ||
]; | ||
|
||
export const subpathFoldersBarrel = ['react']; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
#!/usr/bin/env zx | ||
|
||
import 'zx/globals'; | ||
|
||
import fs from 'fs'; | ||
|
||
const loadJSON = path => JSON.parse(fs.readFileSync(new URL(path, import.meta.url))); | ||
const writeJSON = (path, contents) => | ||
fs.writeFileSync(new URL(path, import.meta.url), JSON.stringify(contents, null, 2)); | ||
|
||
const pkgJsonPlaceholder = name => ({ | ||
main: `../dist/${name}.js`, | ||
}); | ||
const pkgJsonBarrelPlaceholder = name => ({ | ||
main: `../dist/${name}/index.js`, | ||
}); | ||
|
||
async function run() { | ||
const pkgName = argv._[0]; | ||
console.log(`Loading package.json for ${pkgName}`); | ||
const pkgFile = loadJSON(`../packages/${pkgName}/package.json`); | ||
const subpathHelperFile = await import(`../packages/${pkgName}/subpaths.mjs`); | ||
|
||
console.log( | ||
`Found ${subpathHelperFile.subpathNames.length} subpaths and ${subpathHelperFile.subpathFoldersBarrel.length} subpath barrels`, | ||
); | ||
|
||
// Check if pkgFile.files already contains the subpaths. This means that the script has already been run and we should exit early | ||
const subpathsAlreadyAdded = subpathHelperFile.subpathNames.some(name => pkgFile.files.includes(name)); | ||
|
||
if (subpathsAlreadyAdded) { | ||
return console.log(`Subpaths already added to ${pkgName} package.json. Exiting early`); | ||
} | ||
|
||
// Add all subpaths to the "files" property on package.json | ||
pkgFile.files = [...pkgFile.files, ...subpathHelperFile.subpathNames, ...subpathHelperFile.subpathFoldersBarrel]; | ||
|
||
writeJSON(`../packages/${pkgName}/package.json`, pkgFile); | ||
|
||
console.log(`Overwrote package.json for ${pkgName} with subpaths`); | ||
|
||
// Create directories for each subpath name using the pkgJsonPlaceholder | ||
subpathHelperFile.subpathNames.forEach(name => { | ||
fs.mkdirSync(new URL(`../packages/${pkgName}/${name}`, import.meta.url)); | ||
writeJSON(`../packages/${pkgName}/${name}/package.json`, pkgJsonPlaceholder(name)); | ||
}); | ||
|
||
// Create directories for each subpath barrel file using the pkgJsonBarrelPlaceholder | ||
subpathHelperFile.subpathFoldersBarrel.forEach(name => { | ||
fs.mkdirSync(new URL(`../packages/${pkgName}/${name}`, import.meta.url)); | ||
writeJSON(`../packages/${pkgName}/${name}/package.json`, pkgJsonBarrelPlaceholder(name)); | ||
}); | ||
|
||
console.log('Successfully created subpath directories with placeholder files'); | ||
} | ||
|
||
await run(); |