Skip to content

Commit

Permalink
fix(clerk-js): Remove the card glass effect (#2715)
Browse files Browse the repository at this point in the history
  • Loading branch information
anagstef authored Feb 2, 2024
1 parent 2d8c32e commit 13cfbf4
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 13 deletions.
2 changes: 2 additions & 0 deletions .changeset/yellow-papayas-help.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
4 changes: 2 additions & 2 deletions packages/clerk-js/src/ui/elements/Card/CardFooter.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { descriptors, Flex, Link, localizationKeys, useAppearance } from '../../
import { common, mqu, type PropsOfComponent } from '../../styledSystem';
import { colors } from '../../utils';
import { Card } from '.';

type CardFooterProps = PropsOfComponent<typeof Flex>;
export const CardFooter = React.forwardRef<HTMLDivElement, CardFooterProps>((props, ref) => {
const { children, sx, ...rest } = props;
Expand All @@ -23,10 +24,9 @@ export const CardFooter = React.forwardRef<HTMLDivElement, CardFooterProps>((pro
marginTop: `-${t.space.$2}`,
paddingTop: t.space.$2,
background: common.mergedColorsBackground(
colors.setAlpha(t.colors.$colorBackground, 0.8),
colors.setAlpha(t.colors.$colorBackground, 1),
t.colors.$blackAlpha50,
),
backdropFilter: t.backdropFilters.$defaultBlur,
'>:first-of-type': {
padding: `${t.space.$4} ${t.space.$8} ${t.space.$4} ${t.space.$8}`,
},
Expand Down
6 changes: 2 additions & 4 deletions packages/clerk-js/src/ui/elements/Navbar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,9 @@ const NavbarContainer = (
width: t.sizes.$57,
maxWidth: t.space.$57,
background: common.mergedColorsBackground(
colors.setAlpha(t.colors.$colorBackground, 0.8),
colors.setAlpha(t.colors.$colorBackground, 1),
t.colors.$blackAlpha50,
),
backdropFilter: t.backdropFilters.$defaultBlur,
padding: `${t.space.$6} ${t.space.$5} ${t.space.$4} ${t.space.$3}`,
marginRight: `-${t.space.$2}`,
color: t.colors.$colorText,
Expand Down Expand Up @@ -303,10 +302,9 @@ export const NavbarMenuButtonRow = ({ navbarTitleLocalizationKey, ...props }: Na
sx={t => ({
display: 'none',
background: common.mergedColorsBackground(
colors.setAlpha(t.colors.$colorBackground, 0.8),
colors.setAlpha(t.colors.$colorBackground, 1),
t.colors.$blackAlpha50,
),
backdropFilter: t.backdropFilters.$defaultBlur,
padding: `${t.space.$2} ${t.space.$3} ${t.space.$4} ${t.space.$3}`,
marginBottom: `-${t.space.$2}`,
[mqu.md]: {
Expand Down
3 changes: 1 addition & 2 deletions packages/clerk-js/src/ui/elements/PopoverCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ const PopoverCardRoot = React.forwardRef<HTMLDivElement, PropsOfComponent<typeof
width: t.sizes.$94,
maxWidth: `calc(100vw - ${t.sizes.$8})`,
zIndex: t.zIndices.$modal,
backdropFilter: t.backdropFilters.$defaultBlur,
borderRadius: t.radii.$xl,
animation: `${animations.dropdownSlideInScaleAndFade} ${t.transitionDuration.$fast}`,
})}
Expand Down Expand Up @@ -62,7 +61,7 @@ const PopoverCardFooter = (props: PropsOfComponent<typeof Flex>) => {
sx={[
t => ({
background: common.mergedColorsBackground(
colors.setAlpha(t.colors.$colorBackground, 0.8),
colors.setAlpha(t.colors.$colorBackground, 1),
t.colors.$blackAlpha50,
),
marginTop: `-${t.space.$2}`,
Expand Down
3 changes: 0 additions & 3 deletions packages/clerk-js/src/ui/foundations/backdropFilters.ts

This file was deleted.

2 changes: 0 additions & 2 deletions packages/clerk-js/src/ui/foundations/defaultFoundations.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { backdropFilters } from './backdropFilters';
import { borders } from './borders';
import { colors } from './colors';
import { opacity } from './opacity';
Expand All @@ -24,7 +23,6 @@ const defaultInternalThemeFoundations = Object.freeze({
sizes,
space,
shadows,
backdropFilters,
transitionProperty,
transitionTiming,
transitionDuration,
Expand Down

0 comments on commit 13cfbf4

Please sign in to comment.