feat: Updates User List to support created_at & last_active_at date filters #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkats
approved these changes
Oct 31, 2024
CHANGELOG.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| # Changelog | |||
|
|
|||
| ## 2.1.1 | |||
There was a problem hiding this comment.
💯 Thank you for adding a changelog entry!
❓ Should we avoid adding a header for the version until we actually release it?
The next version bump could also be minor (not patch). Is it better if we leave the entries at the top without a header? I guess it doesn't matter much, but it would be good to follow a convention among us.
Feel free to leave as is.
There was a problem hiding this comment.
❓ Should we avoid adding a header for the version until we actually release it?
You know, this is a good idea. I thought of this exact problem when I was typing up this header.
Perhaps we can use the header ## Next release, just so it's contextualized to anyone who peeks the changelog?
This work has yet to be released. When we cut a release, we will update the changelog header to be the release number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
CreatedAtBefore,CreatedAtAfter,LastActiveAtBeforeandLastActiveAtAftertouser.ListParams.